Skip to content

Merge pull request #102 from SchweizerischeBundesbahnen/feature/picker #4

Merge pull request #102 from SchweizerischeBundesbahnen/feature/picker

Merge pull request #102 from SchweizerischeBundesbahnen/feature/picker #4

GitHub Actions / Analysis of design_system_flutter succeeded Dec 15, 2023 in 21s

Package analysis results for design_system_flutter

Score

100/130 points
(76.92307692307692%)

Supported platforms

  • Flutter
    • android
    • ios
    • windows
    • linux
    • macos
    • web

Details

Follow Dart file conventions (20/30)

❌ 0/10 points: Provide a valid pubspec.yaml

The package description is too short.

Add more detail to the description field of pubspec.yaml. Use 60 to 180 characters to describe the package, what it does, and its target use case.

Homepage URL doesn't exist.

At the time of the analysis https://mob.sbb.ch was unreachable. Make sure that the website is reachable via HEAD requests.

✔ 5/5 points: Provide a valid README.md

✔ 5/5 points: Provide a valid CHANGELOG.md

✔ 10/10 points: Use an OSI-approved license

Detected license: MIT.

Provide documentation (10/10)

✔ 10/10 points: Package has an example

Platform support (20/20)

✔ 20/20 points: Supports 6 of 6 possible platforms (iOS, Android, Web, Windows, MacOS, Linux)

  • ✓ Android
  • ✓ iOS
  • ✓ Windows
  • ✓ Linux
  • ✓ MacOS
  • ✓ Web

Pass static analysis (30/50)

❌ 30/50 points: code has no errors, warnings, lints, or formatting issues

Found 15 issues. Showing the first 2:

WARNING: The value of the local variable 'textStyle' isn't used.

lib/src/button/sbb_icon_text_button.dart:45:11

   ╷
45 │     final textStyle = _isPressed || _hasFocus
   │           ^^^^^^^^^
   ╵

To reproduce make sure you are using the lints_core and run flutter analyze lib/src/button/sbb_icon_text_button.dart

WARNING: The left operand can't be null, so the right operand is never executed.

lib/src/theme/styles/src/sbb_base_style.dart:222:43

    ╷
222 │       redTextTheme: this!.redTextTheme ?? other?.redTextTheme,
    │                                           ^^^^^^^^^^^^^^^^^^^
    ╵

To reproduce make sure you are using the lints_core and run flutter analyze lib/src/theme/styles/src/sbb_base_style.dart

Support up-to-date dependencies (20/20)

✔ 10/10 points: All of the package dependencies are supported in the latest version

Package Constraint Compatible Latest
flutter flutter 0.0.0 0.0.0
Transitive dependencies
Package Constraint Compatible Latest
characters - 1.3.0 1.3.0
collection - 1.17.1 1.18.0
js - 0.6.7 0.6.7
material_color_utilities - 0.2.0 0.8.0
meta - 1.9.1 1.11.0
sky_engine - 0.0.99 0.0.99
vector_math - 2.1.4 2.1.4

To reproduce run dart pub outdated --no-dev-dependencies --up-to-date --no-dependency-overrides.

✔ 10/10 points: Package supports latest stable Dart and Flutter SDKs

Versions