feat: use metadata prop Bundle-SymbolicName as artifact id. (#75)

* feat: use metadata prop Bundle-SymbolicName as artifact id and Origin-Bundle-SymbolicName as fallback
* ci: update to latest Sonar scan task und install Java 17 required for the scan to run

.github/workflows/node-ci.yml

@@ -11,7 +11,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - uses: SonarSource/[email protected]
+      - uses: actions/setup-java@v2
+        with:
+          java-version: '17'
+          distribution: 'adopt'
+      - uses: SonarSource/[email protected]
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

src/lib/client/ManifestReader.ts

@@ -33,8 +33,8 @@ export default class ManifestReader {
     getArtifactMetadata(): Artifact {
         return {
             Id:
-                (this.manifestEntries.get('Origin-Bundle-SymbolicName') as string) ||
-                (this.manifestEntries.get('Bundle-SymbolicName') as string).split(';')[0],
+                (this.manifestEntries.get('Bundle-SymbolicName') as string).split(';')[0] ||
+                (this.manifestEntries.get('Origin-Bundle-SymbolicName') as string),
             Version: this.manifestEntries.get('Bundle-Version') as string,
             Name: this.manifestEntries.get('Bundle-Name') as string,
             Type: this.manifestEntries.get('SAP-BundleType') as ArtifactType,

src/test/Testpackage/com.sap.SFIHCM03.hcm2bizx.SFSFOffboardingGetOffboardUserRecordWithExpabcd.EBZ/META-INF/MANIFEST.MF

@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-Description: 
 Bundle-SymbolicName: com.sap.SFIHCM03.hcm2bizx.SFSFOffboardingGetOffbo
- ardUserRecordWithExpabcd; singleton:=true
+ ardUserRecordWithExpabcd.EBZ; singleton:=true
 Origin-Bundle-SymbolicName: com.sap.SFIHCM03.hcm2bizx.SFSFOffboardingG
  etOffboardUserRecordWithExpabcd
 Bundle-ManifestVersion: 2

src/test/integration/IntegrationFlow.test.ts

@@ -32,7 +32,7 @@ describe('Integration flow', () => {
         });
 
         it('fetch an integration flow ', async () => {
-            const iFlowId = sciRestClient.getArtifactMetadata(path.join(artiFactDirectory, 'TestPackage', iFlowFolder)).Id;
+            const iFlowId = sciRestClient.getArtifactMetadata(path.join(artiFactDirectory, 'Testpackage', iFlowFolder)).Id;
             const readStream = (await sciRestClient.getArtifact(iFlowId, '1.0.0', 'IntegrationFlow')) as ReadStream;
 
             const writer = fs.createWriteStream(path.join(artiFactDirectory, 'test.zip'));