Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add API to verify all the hashes and signature #37

Merged
merged 2 commits into from
May 12, 2024

Conversation

pleonex
Copy link
Member

@pleonex pleonex commented May 12, 2024

Add a couple of methods to verify the status of every hash in the ROM header. They take into a account if the hash is present or not, depending on the console (DS / DSi).
It also verifies the signature only on DSi software.

Also bump dependencies.

Quality check list

  • Related code has been tested automatically or manually
  • Related documentation is updated
  • I acknowledge I have read and filled this checklist and accept the
    developer certificate of origin

Acceptance criteria

One API to verify the validity of a ROM

Follow-up work

None

Example

bool hasValidHashes = programInfo.HasValidHashes();
bool hasValidSignature = programInfo.HasValidSignature();

@pleonex pleonex added the enhancement New feature or request label May 12, 2024
@pleonex pleonex self-assigned this May 12, 2024
@pleonex pleonex marked this pull request as ready for review May 12, 2024 19:16
@pleonex pleonex merged commit 5864da7 into main May 12, 2024
5 checks passed
@pleonex pleonex deleted the feature/hash-verify-methods branch May 12, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant