added filter method support #196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there
I added support for generic filter functions. My use-case:
The user can select multiple criteria from a drop-down in the header. Items are kept if they match any of these criteria (OR). This is just what I needed, though. The implementation in iron-data-table is generic and can be used for any complex filter task like combining filters from several columns or whatever.
I tried to touch as little of the existing code as possible, however, I needed to change the way filters are indexed because filter-functions do not have a filterBy property (it's not required and potentially makes the usage of filter functions more difficult for client programmers if it were) which was used as a key for filters. This may change the behavior where client programmers did unhealthy things like using the same filterBy in multiple columns.
I modeled the feature after the "filter" property of Polymer's dom-repeat.
Ugh, and thanks for that great table, love it :-)
This change is