Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS variables for cell height #177

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Storyyeller
Copy link

@Storyyeller Storyyeller commented Dec 20, 2016

This is the same as #165 except that it also applies the variables to data-table-checkbox, which is required in order to make the table work when multiSelect is enabled.

The reason this is necessary is because normal CSS selectors such as the following don't work with the Shadow DOM, i.e. it breaks in any browser which implements web components without a polyfill.

iron-data-table data-table-cell {
  height: 100px;
}

This change is Reviewable

@Saulis
Copy link
Owner

Saulis commented Dec 20, 2016

Hi!

Please see my comment here: #147 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants