Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BigInt to int conversions #342

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: BigInt to int conversions #342

wants to merge 1 commit into from

Conversation

kumulynja
Copy link

This PR fixes some conversion issues between BigInt and int types in bdk's getTransactions function causing it to throw an error and not show the transaction history.

@kumulynja kumulynja mentioned this pull request Dec 13, 2024
Open
DanGould
DanGould approved these changes Dec 14, 2024
View reviewed changes
Copy link
Contributor

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK b39de1d

This fixes my history problem and closes #340

Would be good to be able to test this to prevent it from regressing, but the fix is better then the broken version so I'm comfortable merging as-is.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanGould DanGould DanGould approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumulynja @DanGould