Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.16.z] create a fake ntp module for FAM tests #16999

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[6.16.z] create a fake ntp module for FAM tests #16999

merged 1 commit into from
Nov 25, 2024
+14 −12

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #16997

Problem Statement

The ntp module in the fixtures is too old, but we also only need a few params from it.

Solution

Drop the install code and use the fake code to create a module as the tests expect

Related Issues

@evgeni @web-flow
create a fake ntp module for FAM tests (#16997)
7fcb005 
* use sat.put() instead of sat.execute(echo) to place puppet files

* allow passing in custom module code

* create a fake ntp module

the one in the repo is too old

(cherry picked from commit 39769a5)
@Satellite-QE Satellite-QE added 6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA labels Nov 25, 2024
@Satellite-QE Satellite-QE requested a review from a team as a code owner November 25, 2024 12:29
@Satellite-QE Satellite-QE added the No-CherryPick PR doesnt need CherryPick to previous branches label Nov 25, 2024
@Satellite-QE
Copy link
Collaborator Author 

trigger: test-robottelo
pytest: tests/foreman/sys/test_fam.py::test_positive_run_modules_and_roles[smart_class_parameter_override_value] tests/foreman/sys/test_fam.py::test_positive_run_modules_and_roles[smart_class_parameter] tests/foreman/sys/test_fam.py::test_positive_run_modules_and_roles[config_group]

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Nov 25, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 9454
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/sys/test_fam.py::test_positive_run_modules_and_roles[smart_class_parameter_override_value] tests/foreman/sys/test_fam.py::test_positive_run_modules_and_roles[smart_class_parameter] tests/foreman/sys/test_fam.py::test_positive_run_modules_and_roles[config_group] --external-logging
Test Result : ================= 3 passed, 31 warnings in 1014.23s (0:16:54) ==================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 25, 2024
@Satellite-QE Satellite-QE merged commit 921e788 into 6.16.z Nov 25, 2024
17 of 18 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.16.z-39769a501a118c916923c30769a813cdef023cf6 branch November 25, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni approved these changes

Assignees

@evgeni evgeni

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Satellite-QE @evgeni