Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify FAM test command #16980

Merged
merged 1 commit into from
Nov 22, 2024
Merged

simplify FAM test command #16980

merged 1 commit into from
Nov 22, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Nov 21, 2024

Problem Statement

The command we use to execute FAM tests is complicated and uses shell chaining which is not well readable

Solution

  • we don't need to export vars, setting them should be sufficient
  • make can change directories for us, no need to cd

Related Issues

@evgeni
simplify FAM test command
c1bc98f 
- we don't need to export vars, setting them should be sufficient
- make can change directories for us, no need to cd
@evgeni evgeni requested a review from a team as a code owner November 21, 2024 15:21
@evgeni
Copy link
Member Author

evgeni commented Nov 21, 2024 

trigger: test-robottelo
pytest: tests/foreman/sys/test_fam.py
env:
    BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9435
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/sys/test_fam.py --external-logging
Test Result : =========== 17 failed, 93 passed, 352 warnings in 4954.49s (1:22:34) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Nov 21, 2024
@evgeni
Copy link
Member Author

evgeni commented Nov 21, 2024 

trigger: test-robottelo
pytest: tests/foreman/sys/test_fam.py -vv
env:
    BROKER_SSH_BACKEND: hussh

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9440
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/sys/test_fam.py -vv --external-logging
Test Result : =========== 17 failed, 93 passed, 443 warnings in 5366.39s (1:29:26) ===========

@evgeni
Copy link
Member Author

evgeni commented Nov 21, 2024 

trigger: test-robottelo
pytest: tests/foreman/sys/test_fam.py -vv

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9442
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/sys/test_fam.py -vv --external-logging
Test Result : =========== 16 failed, 94 passed, 441 warnings in 7910.99s (2:11:50) ===========

@jameerpathan111 jameerpathan111 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.16.z Introduced in or relating directly to Satellite 6.16 labels Nov 22, 2024
@jameerpathan111 jameerpathan111 merged commit fefe1ea into master Nov 22, 2024
10 of 13 checks passed
@jameerpathan111 jameerpathan111 deleted the fam-command branch November 22, 2024 06:48
github-actions bot pushed a commit that referenced this pull request Nov 22, 2024
@evgeni @web-flow
simplify FAM test command (#16980)
3e7484a 
- we don't need to export vars, setting them should be sufficient
- make can change directories for us, no need to cd

(cherry picked from commit fefe1ea)
@Satellite-QE Satellite-QE mentioned this pull request Nov 22, 2024
Merged
jameerpathan111 pushed a commit that referenced this pull request Nov 22, 2024
@Satellite-QE @evgeni
[6.16.z] simplify FAM test command (#16982)
3842bd2 
simplify FAM test command (#16980)

- we don't need to export vars, setting them should be sufficient
- make can change directories for us, no need to cd

(cherry picked from commit fefe1ea)

Co-authored-by: Evgeni Golov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

Assignees

@evgeni evgeni

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgeni @Satellite-QE @jameerpathan111