[CC Automation] Test for Scheduled insights sync job #16913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColeHiggins2
added
CherryPick
chris1984
approved these changes
Nov 13, 2024
| module_target_sat, | ||
| ): | ||
| """Verify that triggering the InsightsScheduledSync job in Satellite succeeds with no errors | ||
| :id: 59f66062-2865-4cca-82bb-8d0501fd40f1 |
There was a problem hiding this comment.
@ColeHiggins2 add a blank line here so that the sphinx is satisfied, you can check it locally using make test-docstrings
Suggested change
| :id: 59f66062-2865-4cca-82bb-8d0501fd40f1 | |
| :id: 59f66062-2865-4cca-82bb-8d0501fd40f1 |
Otherwise seems good to me!
LadislavVasina1
requested changes
Nov 14, 2024
|
And also can we run some PRT on this please? |
vsedmik
requested changes
Nov 14, 2024
| task_output = module_target_sat.api.ForemanTask().search( | ||
| query={'search': f'id = {inventory_sync["task"]["id"]}'} | ||
| ) | ||
| assert task_output[0].output['host_statuses']['sync'] == 2 |
There was a problem hiding this comment.
@ColeHiggins2 Could we define/name some constant for this so we know what it means?
Maybe in robottelo/constants/__init__.py something like
INSIGHT_SYNC_STATUS = Box(OK = 2, FAIL = 3, UNKNOWN = 42)
and use it globally? (I've seen it at more places already)
assert task_output[0].output['host_statuses']['sync'] == INSIGHT_SYNC_STATUS.OK
I think @toledo would know the valid statuses, he could help here.
(I used Box coz I like . syntax, but could be dict or anything.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.