Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Data telemetry option from convert2rhel tests #15512

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Remove Data telemetry option from convert2rhel tests #15512

merged 2 commits into from
Jul 5, 2024

Conversation

Gauravtalreja1
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 commented Jun 26, 2024 •
edited
Loading

Problem Statement

Data telemetry input/option is removed from convert2rhel job templates in theforeman/foreman_ansible#710

Solution

Remove Data telemetry input/option from convert2rhel tests

Also, Adding check to vefify convert2rhel conversion facts to cover SAT-24654

@Gauravtalreja1 Gauravtalreja1 added Easy Fix :) Easiest Fix to review and quick merge request. CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.15.z Introduced in or relating directly to Satellite 6.15 labels Jun 26, 2024
@Gauravtalreja1 Gauravtalreja1 self-assigned this Jun 26, 2024
@Gauravtalreja1 Gauravtalreja1 requested a review from a team as a code owner June 26, 2024 07:11
@Gauravtalreja1 Gauravtalreja1 force-pushed the remove-data-telemetry-c2r branch from 9e2d010 to bb00374 Compare June 28, 2024 10:17
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7573
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_convert2rhel.py --external-logging
Test Result : ================= 4 failed, 906 warnings in 6264.96s (1:44:24) =================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jun 28, 2024
@shweta83
Copy link
Contributor

shweta83 commented Jul 1, 2024

@Gauravtalreja1 Can you please check the failures on this PR?

@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py -k "test_convert2rhel_oracle_with_pre_conversion_template_check[oracle7] or test_convert2rhel_centos_with_pre_conversion_template_check[centos7]"

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7583
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_convert2rhel.py --external-logging
Test Result : ============ 3 failed, 669 warnings, 1 error in 5084.26s (1:24:44) =============

@shweta83 shweta83 mentioned this pull request Jul 1, 2024
Merged
@Gauravtalreja1 Gauravtalreja1 force-pushed the remove-data-telemetry-c2r branch 2 times, most recently from c4e55cd to 9b26ce6 Compare July 3, 2024 09:39
@Gauravtalreja1 Gauravtalreja1 force-pushed the remove-data-telemetry-c2r branch from 9b26ce6 to f937e46 Compare July 4, 2024 07:49
@Gauravtalreja1
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_convert2rhel.py

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7639
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_convert2rhel.py --external-logging
Test Result : ======= 1 failed, 1 passed, 616 warnings, 2 errors in 4805.17s (1:20:05) =======

@Gauravtalreja1
Copy link
Collaborator Author

PRT passed for centos8 conversion, while other conversions fails due to intermittent issues, so I'd request to review/merge

shweta83
shweta83 approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@shweta83 shweta83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@shweta83
Copy link
Contributor

shweta83 commented Jul 5, 2024

The scope of this PR has been completed and passing and the failures are unrelated to this change so it should be good to merge this PR.

shubhamsg199
shubhamsg199 approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@shubhamsg199 shubhamsg199 merged commit b8ca3ee into SatelliteQE:master Jul 5, 2024
8 of 9 checks passed
@Satellite-QE Satellite-QE mentioned this pull request Jul 5, 2024
Closed
@Gauravtalreja1 Gauravtalreja1 deleted the remove-data-telemetry-c2r branch July 5, 2024 08:49
@Gauravtalreja1 Gauravtalreja1 mentioned this pull request Jul 5, 2024
Closed
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@Gauravtalreja1 @jyejare
Remove Data telemetry option from convert2rhel tests (SatelliteQE#15512)
6affbe2 
* Remove Data telemetry option from convert2rhel tests

Signed-off-by: Gaurav Talreja <[email protected]>

* Add check to vefify convert2rhel conversion facts

Signed-off-by: Gaurav Talreja <[email protected]>

---------

Signed-off-by: Gaurav Talreja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

@shweta83 shweta83 shweta83 approved these changes

Assignees

@Gauravtalreja1 Gauravtalreja1

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request. PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gauravtalreja1 @Satellite-QE @shweta83 @shubhamsg199