Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CV Eval] add test for customer case bz #15268

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

sambible
Copy link
Contributor

@sambible sambible commented Jun 3, 2024

Problem Statement

Adding BZ coverage for https://bugzilla.redhat.com/show_bug.cgi?id=2227271

Requires: SatelliteQE/airgun#1411

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py -k 'test_republish_metadata'
airgun: 1411

@sambible sambible added CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z labels Jun 3, 2024
@sambible sambible self-assigned this Jun 3, 2024
@sambible sambible requested a review from a team as a code owner June 3, 2024 07:54
@sambible
Copy link
Contributor Author

sambible commented Jun 3, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py -k 'test_republish_metadata'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7246
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py -k test_republish_metadata --external-logging
Test Result : =========== 1 failed, 2 deselected, 12 warnings in 792.86s (0:13:12) ===========

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Jun 3, 2024
@jyejare jyejare removed the 6.16.z label Jun 5, 2024
@sambible
Copy link
Contributor Author

sambible commented Jul 3, 2024

@omkarkhatavkar

@sambible
Copy link
Contributor Author

sambible commented Jul 3, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py -k 'test_republish_metadata'
airgun: 1411

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7628
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py -k test_republish_metadata --external-logging
Test Result : =========== 1 failed, 4 deselected, 18 warnings in 924.11s (0:15:24) ===========

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7629
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py -k test_republish_metadata --external-logging
Test Result : =========== 1 failed, 4 deselected, 18 warnings in 859.29s (0:14:19) ===========

@sambible
Copy link
Contributor Author

sambible commented Jul 3, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py -k 'test_republish_metadata'
airgun: 1411

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7630
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py -k test_republish_metadata --external-logging
Test Result : =========== 1 failed, 4 deselected, 18 warnings in 795.00s (0:13:14) ===========

@sambible
Copy link
Contributor Author

sambible commented Jul 9, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py -k 'test_republish_metadata'
airgun: 1411

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7686
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py -k test_republish_metadata --external-logging
Test Result : ========== 1 failed, 4 deselected, 18 warnings in 1081.72s (0:18:01) ===========

@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py -k 'test_republish_metadata'
airgun: 1411

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7703
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py -k test_republish_metadata --external-logging
Test Result : =========== 1 failed, 4 deselected, 18 warnings in 784.62s (0:13:04) ===========

@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py -k 'test_republish_metadata'
airgun: 1411

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7704
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py -k test_republish_metadata --external-logging
Test Result : =========== 1 failed, 4 deselected, 18 warnings in 789.06s (0:13:09) ===========

Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy requested changes

Comment on lines +150 to +152
target_sat.cli.ContentView.version_republish_repositories(
{'id': version.id, 'force': 'false'}
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
target_sat.cli.ContentView.version_republish_repositories(
{'id': version.id, 'force': 'false'}
)
target_sat.cli.ContentView.version_republish_repositories(
{'id': version.id}
)

Passing 'force': 'false' is optional I guess, could you please check it locally and update here

)
rh_repo = target_sat.api.Repository(id=rh_repo_id).read()
cv = target_sat.api.ContentView(organization=function_sca_manifest_org).create()
cv = target_sat.api.ContentView(id=cv.id, repository=[rh_repo]).update(["repository"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cv = target_sat.api.ContentView(id=cv.id, repository=[rh_repo]).update(["repository"])
cv = target_sat.api.ContentView(id=cv.id, repository=[rh_repo]).update(['repository'])

Comment on lines +126 to +128
5. Verify that you can't click the "republish metadata" option from the UI
6. Verify that you can't republish metadata from the cli without the force option
7. Verify that you can republish metadata from the CLI using the --force option
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
5. Verify that you can't click the "republish metadata" option from the UI
6. Verify that you can't republish metadata from the cli without the force option
7. Verify that you can republish metadata from the CLI using the --force option
5. Verify that the "republish metadata" option from the UI doesn't work
6. Verify that the "republish metadata" from the CLI without the force option doesn't work
7. Verify that the "republish metadata" from the CLI using the --force = true/yes/1 does work

@@ -110,6 +113,53 @@ def test_no_blank_page_on_language_switch(session, target_sat, module_org):
assert session.contentview_new.read_french_lang_cv()


def test_republish_metadata(session, function_sca_manifest_org, target_sat):
"""Verify that you can't republish metadata from the UI, and you can from the CLI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Verify that you can't republish metadata from the UI, and you can from the CLI
"""Verify that republish metadata from the UI doesn't work and from the CLI it does work with --force true/yes/1 option

6. Verify that you can't republish metadata from the cli without the force option
7. Verify that you can republish metadata from the CLI using the --force option

:expectedresults: You can't republish RH Repo metadata from the UI, and can from the CLI with --force
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:expectedresults: You can't republish RH Repo metadata from the UI, and can from the CLI with --force
:expectedresults: "republish RH Repo metadata" from UI not worked and it worked from the CLI with --force true/yes/1 option

@jameerpathan111
Copy link
Contributor

@sambible I'm converting this pr to draft for now, please mark it ready for review once you're done with changes/addressing the comments.

@jameerpathan111 jameerpathan111 marked this pull request as draft August 20, 2024 14:37
@jyejare jyejare added the 6.16.z Introduced in or relating directly to Satellite 6.16 label Aug 22, 2024
@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py -k 'test_republish_metadata'
airgun: 1411

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9026
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py -k test_republish_metadata --external-logging
Test Result : =========== 1 failed, 4 deselected, 18 warnings in 669.52s (0:11:09) ===========

@damoore044
Copy link
Contributor

@sambible if you rebase the Airgun PR with changes we merged yesterday, prt may pass for you now as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants