-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto Release Robottelo #11365
Auto Release Robottelo #11365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely a huge improvement and a nicer solution than the previously presented one. 👍
However this solution works, I have found the following GH Action that does everything in three steps compared to the 5 steps in your solution.
https://github.com/Bullrich/generate-release-changelog
Take it as a possible enhancement or simplification. This comment is definitely non-blocking.
@ogajduse We need not to use a github action to generate release notes as the HTTP request for creating a release provides a simple parameter to generate release notes. Also I contributed to action-automatic-releases that releases on tag to genrate-release-notes automatically (marvinpinto/action-automatic-releases#4 ) and the plan in the future is to use that. |
- name: Push the tag to the upstream | ||
run: "git push ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}.git --tags" | ||
|
||
- name: create a new release from the tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just of consistencyCreate a new release from the tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, non blocking comment
- name: create a new release from the tag | ||
env: | ||
credentials: ${{ secrets.GH_TOKEN }} | ||
run: "curl -L -X POST -H \"Authorization: Bearer ${{ secrets.SATQE_GH_TOKEN }}\" ${GITHUB_API_URL}/repos/${GITHUB_REPOSITORY}/releases -d '{\"tag_name\": \"${{ github.event.inputs.tag_name }}\", \"target_commitish\":\"master\", \"name\":\"${{ github.event.inputs.tag_name }}\", \"draft\":false, \"prerelease\":true, \"generate_release_notes\": true}'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a check here that the release was successful, if not add a slack notification.
@omkarkhatavkar I shall handle your last comment in improvement PR. Until then I ll merge the PR. |
Now, the release for changelogs will be tagged in this repo from the SatQE CI job.
How?
auto release
workflow in this repo (created in this PR)So all the releases here would now be automatically created.