Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Release Robottelo #11365

Merged
merged 1 commit into from
May 17, 2023
Merged

Auto Release Robottelo #11365

merged 1 commit into from
May 17, 2023

Conversation

jyejare
Copy link
Member

@jyejare jyejare commented Apr 27, 2023

Now, the release for changelogs will be tagged in this repo from the SatQE CI job.

How?

  1. Upon receiving UMB message for the new snap for a major downstream release in development, the CI job triggers.
  2. The CI job sends an HTTP dispatch request to the auto release workflow in this repo (created in this PR)
  3. Upon receiving the HTTP request, the workflow runs with new tag name and creates a new tag in the repo.
  4. The same tag is then used to create a new release with automatic release notes.

So all the releases here would now be automatically created.

@jyejare jyejare added the CherryPick PR needs CherryPick to previous branches label Apr 27, 2023
@jyejare jyejare added No-CherryPick PR doesnt need CherryPick to previous branches and removed CherryPick PR needs CherryPick to previous branches labels Apr 27, 2023
@jyejare jyejare force-pushed the dispatch_release branch from 87578d8 to d8407a3 Compare May 2, 2023 07:42
@jyejare jyejare added the Framework Changes A modification of the robottelo framework label May 2, 2023
Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely a huge improvement and a nicer solution than the previously presented one. 👍

However this solution works, I have found the following GH Action that does everything in three steps compared to the 5 steps in your solution.
https://github.com/Bullrich/generate-release-changelog

Take it as a possible enhancement or simplification. This comment is definitely non-blocking.

@jyejare
Copy link
Member Author

jyejare commented May 4, 2023

@ogajduse We need not to use a github action to generate release notes as the HTTP request for creating a release provides a simple parameter to generate release notes. Also I contributed to action-automatic-releases that releases on tag to genrate-release-notes automatically (marvinpinto/action-automatic-releases#4 ) and the plan in the future is to use that.

@jyejare jyejare force-pushed the dispatch_release branch from d8407a3 to 65510b6 Compare May 4, 2023 09:32
- name: Push the tag to the upstream
run: "git push ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}.git --tags"

- name: create a new release from the tag

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just of consistencyCreate a new release from the tag

Copy link

@omkarkhatavkar omkarkhatavkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, non blocking comment

- name: create a new release from the tag
env:
credentials: ${{ secrets.GH_TOKEN }}
run: "curl -L -X POST -H \"Authorization: Bearer ${{ secrets.SATQE_GH_TOKEN }}\" ${GITHUB_API_URL}/repos/${GITHUB_REPOSITORY}/releases -d '{\"tag_name\": \"${{ github.event.inputs.tag_name }}\", \"target_commitish\":\"master\", \"name\":\"${{ github.event.inputs.tag_name }}\", \"draft\":false, \"prerelease\":true, \"generate_release_notes\": true}'"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a check here that the release was successful, if not add a slack notification.

@jyejare
Copy link
Member Author

jyejare commented May 17, 2023

@omkarkhatavkar I shall handle your last comment in improvement PR. Until then I ll merge the PR.

@jyejare jyejare merged commit 83d165e into SatelliteQE:master May 17, 2023
ColeHiggins2 pushed a commit to ColeHiggins2/robottelo that referenced this pull request Oct 9, 2023
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Changes A modification of the robottelo framework No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants