Modify content and return value after timeout #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR expicitly sets manifest.content to `None` and returns the manifest object when a manifest export job times out. This change facilitates the failover to cloned manifests in Robottelo. Previously, failed export jobs triggered an exception in Robottelo when manifester fixtures attempted to upload manifests because, in those cases, the manifest object did not contain a `content` attribute.
synkd
added a commit
to synkd/robottelo
that referenced
this pull request
Sep 6, 2023
This PR, in combination with SatelliteQE/manifester#21, addresses some of the errors that have been occurring in CI in cases where Manifester times out when exporting a manifest due to an upstream RHSM issue. These changes should enable Robottelo to successfully fail over to using cloned manifests in those cases.
jyejare
approved these changes
Sep 11, 2023
Gauravtalreja1
approved these changes
Sep 11, 2023
JacobCallahan
pushed a commit
to SatelliteQE/robottelo
that referenced
this pull request
Sep 12, 2023
This PR, in combination with SatelliteQE/manifester#21, addresses some of the errors that have been occurring in CI in cases where Manifester times out when exporting a manifest due to an upstream RHSM issue. These changes should enable Robottelo to successfully fail over to using cloned manifests in those cases.
github-actions bot
pushed a commit
to SatelliteQE/robottelo
that referenced
this pull request
Sep 12, 2023
This PR, in combination with SatelliteQE/manifester#21, addresses some of the errors that have been occurring in CI in cases where Manifester times out when exporting a manifest due to an upstream RHSM issue. These changes should enable Robottelo to successfully fail over to using cloned manifests in those cases. (cherry picked from commit b2f69d5)
github-actions bot
pushed a commit
to SatelliteQE/robottelo
that referenced
this pull request
Sep 12, 2023
This PR, in combination with SatelliteQE/manifester#21, addresses some of the errors that have been occurring in CI in cases where Manifester times out when exporting a manifest due to an upstream RHSM issue. These changes should enable Robottelo to successfully fail over to using cloned manifests in those cases. (cherry picked from commit b2f69d5)
github-actions bot
pushed a commit
to SatelliteQE/robottelo
that referenced
this pull request
Sep 12, 2023
This PR, in combination with SatelliteQE/manifester#21, addresses some of the errors that have been occurring in CI in cases where Manifester times out when exporting a manifest due to an upstream RHSM issue. These changes should enable Robottelo to successfully fail over to using cloned manifests in those cases. (cherry picked from commit b2f69d5)
Gauravtalreja1
pushed a commit
to SatelliteQE/robottelo
that referenced
this pull request
Sep 12, 2023
Debug failover to cloned manifests (#12515) This PR, in combination with SatelliteQE/manifester#21, addresses some of the errors that have been occurring in CI in cases where Manifester times out when exporting a manifest due to an upstream RHSM issue. These changes should enable Robottelo to successfully fail over to using cloned manifests in those cases. (cherry picked from commit b2f69d5) Co-authored-by: synkd <[email protected]>
Gauravtalreja1
pushed a commit
to SatelliteQE/robottelo
that referenced
this pull request
Sep 12, 2023
Debug failover to cloned manifests (#12515) This PR, in combination with SatelliteQE/manifester#21, addresses some of the errors that have been occurring in CI in cases where Manifester times out when exporting a manifest due to an upstream RHSM issue. These changes should enable Robottelo to successfully fail over to using cloned manifests in those cases. (cherry picked from commit b2f69d5) Co-authored-by: synkd <[email protected]>
Gauravtalreja1
pushed a commit
to SatelliteQE/robottelo
that referenced
this pull request
Sep 12, 2023
Debug failover to cloned manifests (#12515) This PR, in combination with SatelliteQE/manifester#21, addresses some of the errors that have been occurring in CI in cases where Manifester times out when exporting a manifest due to an upstream RHSM issue. These changes should enable Robottelo to successfully fail over to using cloned manifests in those cases. (cherry picked from commit b2f69d5) Co-authored-by: synkd <[email protected]>
vsedmik
pushed a commit
to vsedmik/robottelo
that referenced
this pull request
Sep 19, 2023
This PR, in combination with SatelliteQE/manifester#21, addresses some of the errors that have been occurring in CI in cases where Manifester times out when exporting a manifest due to an upstream RHSM issue. These changes should enable Robottelo to successfully fail over to using cloned manifests in those cases.
ColeHiggins2
pushed a commit
to ColeHiggins2/robottelo
that referenced
this pull request
Oct 9, 2023
This PR, in combination with SatelliteQE/manifester#21, addresses some of the errors that have been occurring in CI in cases where Manifester times out when exporting a manifest due to an upstream RHSM issue. These changes should enable Robottelo to successfully fail over to using cloned manifests in those cases.
damoore044
pushed a commit
to damoore044/robottelo
that referenced
this pull request
Oct 10, 2023
This PR, in combination with SatelliteQE/manifester#21, addresses some of the errors that have been occurring in CI in cases where Manifester times out when exporting a manifest due to an upstream RHSM issue. These changes should enable Robottelo to successfully fail over to using cloned manifests in those cases.
shweta83
pushed a commit
to shweta83/robottelo
that referenced
this pull request
Apr 10, 2024
This PR, in combination with SatelliteQE/manifester#21, addresses some of the errors that have been occurring in CI in cases where Manifester times out when exporting a manifest due to an upstream RHSM issue. These changes should enable Robottelo to successfully fail over to using cloned manifests in those cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expicitly sets manifest.content to
Noneand returns the manifest object when a manifest export job times out. This change facilitates the failover to cloned manifests in Robottelo. Previously, failed export jobs triggered an exception in Robottelo when manifester fixtures attempted to upload manifests because, in those cases, the manifest object did not contain acontentattribute.