Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing updated value and takes default value #1643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

removing updated value and takes default value #1643

wants to merge 1 commit into from

Conversation

amolpati30
Copy link
Contributor

Added to the entities with their respective locators:

  • read_update_value: Reads the value after updating the Ansible variable in the host.
  • read_delete_value: Deletes the updated value, reverts to the default value, and reads the default value.

Dependent PR: SatelliteQE/robottelo#16969

@amolpati30 amolpati30 added CherryPick PR needs CherryPick to previous branches 6.13.z AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing 6.14.z 6.15.z 6.16.z labels Nov 20, 2024
@amolpati30 amolpati30 mentioned this pull request Nov 20, 2024
Open
@Satellite-QE
Copy link
Contributor

PRT Result

Build Number: 460
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt -k test_positive_assign_ansible_role_variable_on_host --external-logging
Test Result : ========== 1 passed, 10 deselected, 24 warnings in 837.50s (0:13:57) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Nov 20, 2024
@amolpati30 amolpati30 changed the title removing updated value with default removing updated value and takes default value Nov 20, 2024
LadislavVasina1
LadislavVasina1 reviewed Nov 20, 2024
View reviewed changes
airgun/entities/host_new.py Outdated
@@ -975,6 +975,22 @@ def refresh_applicability(self, entity_name):
self.browser.plugin.ensure_page_safe()
view.dropdown.item_select('Refresh applicability')

def read_update_value(self, entity_name, key, value):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change the wording of the function name.

Suggested change
def read_update_value(self, entity_name, key, value):
def read_updated_value(self, entity_name, key, value):

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the function name.

LadislavVasina1
LadislavVasina1 reviewed Nov 20, 2024
View reviewed changes
airgun/entities/host_new.py
def read_update_value(self, entity_name, key, value):
view = self.navigate_to(self, 'NewDetails', entity_name=entity_name)
wait_for(lambda: view.ansible.variables.table.is_displayed, timeout=10)
view.ansible.variables.table.row(name=key)[5].widget.click()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some comment to the 5 index

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment for the [5] index.

LadislavVasina1
LadislavVasina1 requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change requested, otherwise looks good to me. GJ @amolpati30!

@Satellite-QE
Copy link
Contributor

PRT Result

Build Number: 461
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt -k test_positive_assign_ansible_role_variable_on_host --external-logging
Test Result : ========== 1 failed, 10 deselected, 22 warnings in 800.28s (0:13:20) ===========

@Satellite-QE Satellite-QE added PRT-Failed Indicates that latest PRT run is failed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Nov 22, 2024
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt -k test_positive_assign_ansible_role_variable_on_host
robottelo: 16969

@Satellite-QE
Copy link
Contributor

PRT Result

Build Number: 462
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt -k test_positive_assign_ansible_role_variable_on_host --external-logging
Test Result : ========== 1 passed, 10 deselected, 24 warnings in 892.06s (0:14:52) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Nov 22, 2024
LadislavVasina1
LadislavVasina1 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@amolpati30 amolpati30

Labels
6.13.z 6.14.z 6.15.z 6.16.z AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amolpati30 @Satellite-QE @LadislavVasina1