Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved UI for profile screen #135

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Pranav108
Copy link
Contributor

Program

  • CodePeak
  • Script Winter of Code
  • None

Issue

Fixes #116

Description

This PR will improve UI for profile screen and edit email option is also removed now.

Type of change

You can write manually also

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change

Screenshot

image

Checklist:

  • My code follows the style guidelines of this project
  • The app runs properly
  • I have performed a self-review of my own code
  • I have formatted and commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@Pranav108
Copy link
Contributor Author

@Saransh-cpp sorry for those PR's bro.
This PR has no conflicts and seems fine till now, let me know if need to change something.

@Saransh-cpp
Copy link
Owner

@Pranav108 you will have to fix the linting issues

@Pranav108
Copy link
Contributor Author

Is this okay now?

@Saransh-cpp Saransh-cpp self-requested a review January 12, 2022 10:55
@Saransh-cpp
Copy link
Owner

Hey, I think code peak is over, right? I don't think I will be able to assign points for this. I will obviously review and merge this!

@Saransh-cpp Saransh-cpp added hard Would require your time and patience ui/ux Editing the UI/UX labels Jan 12, 2022
Copy link
Owner

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Pranav108! Looks awesome! Some minor comments -

lib/Screens/profile.dart Show resolved Hide resolved
lib/Screens/profile.dart Show resolved Hide resolved
lib/Screens/profile.dart Show resolved Hide resolved
lib/Screens/profile.dart Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hard Would require your time and patience ui/ux Editing the UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp the profile screen
2 participants