[3.x] (WIP) EncounterFight and state refactor; #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[3.x] Fix Linux build (remove extra qualification)
Fixing source of actorcontrols being always player for single target packets.
statuseffects and autoattack still on the todo list
…ource and target.
3.x crit, fix random generator and remove direct hit
Also reset target and autoattack state on player on change zone.
… exceptions when possible;
…nt (should support overworld now)
- todo: hook this up to EncounterTimeline
- todo: use selector in CastAction timepoint
- timeline cleanup
- fix BNpcSpawn timepoint - temp workaround for actions - fix selectors not working as intended - todo: rewrite this shit to not abuse copy ctors
- add PhaseActive and GetAction conditions - refactor ifrit to use controller
- fix Common::Util::getOffsettedPosition - fix action timepoint getting stuck (todo: fix actions legit)
…s-stuff-rebase2
- add knockback - use pos set in action rather than always using source actor
- pass filters to snapshot - fix replay not formatting debug message correctly
SapphireMordred
merged commit f19d316
into
SapphireServer:those_who_fight
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.