-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scene loader for the map #93
Conversation
This is to not have to write a check everywhere we connect to on_event_end Since on_defeat is a special case and only in one place, it makes sense to have a dedicated signal
Need to add a button to trigger the event_end flag and check everything is still working after
We ensure we trigger only the event of the room we are in by referencing the room the player is in and getting the related event
Since they are in an overlay, the actual reference to instantiate is not the overlay itself but the parent of the overlay
The test now gets the list of const from the script directly This just means all debug var should be const
@Tysterman74 as you can see in my last push i disable the button when the position is not set for the return button, which is another solution to the problem we had with setting a torch when fauna was not in a room (that you solved by adding a pop-up). |
Works since EventRandom.choose_other_event() returns random by default
You did change the default scene from main menu to the mapUI which you might want to change back, but it's not a big deal |
Did I ? That was not voluntary, will change it back to the main menu, what I want is the main menu to load the map when we load a new game |
TODO: load the correct scene for the dialogue event probably load a unique scene but different dialogue in it with the on_event_start
I need to finish setting up the dialogue so it works with the map switch. And I need to add tests. |
TODO: add the overlay to the scene
We can't click on it when the dialogue is going, maybe it should be added as an element of the balloon scene instead of in a separate control like I did
…y calling the on_event_ended
This system with the enum is not ideal...
I think the pop-up is fine. Gives a bit of context and small tutorial to the user instead of leaving it disabled with no context. |
I pulled your branch and everything looks good so far. I did find a bug here when we activate the mob scene and we exit back to main menu, we are not able to start up the game scene again. Was this okay to leave in or should we spin another issue for it? fauna_game_scene_swithc_bug.mp4There is also a bug if we're on the Shop/Heal scene and tap on the Deck icon at the top right it causes a crash. |
I found the bug about going to the main menu. I think this should probably be addressed with the save issue, as solving this implies reloading the scene correctly (which is the goal of the save PR iirc). |
I found the issue, we are kind of paying the price of a pretty hectic organization for how cards are managed. I'll try to think of a solution, the fix is probably coming tomorrow. |
Description
Loads different scenes based on the event of the room clicked on the map
Related issue(s)
Closes #87
List of changes
Tests
None yet, I'll write those once I set everything correctly.
Additional notes
I still need to add things such as:
I'll add a ✅ once those things are done