Heal event interface #147
Merged
Heal event interface #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomzkk
requested changes
Dec 30, 2024
Tomzkk
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an actual heal event, where the player gets healed for 25% of their max HP
Related issue(s)
In link with #146 but doesn't close it
List of changes
Tests
Removed the
naming_convention_testas I think it's not flexible at all. When I first wrote the test, the project was way smaller, but the naming convention is too rigid and also doesn't provide much value.Additional notes
The card removal in the heal event mentioned in #146 should be in another PR