-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enemy attack pattern #144
Open
Turtyo
wants to merge
21
commits into
Saplings-Projects:main
Choose a base branch
from
Turtyo:127-Enemy_attack_pattern
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enemy attack pattern #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The targeting is different so there needs to be separate cards
Now that the overstress is an export, it can be varied and testing that doesn't make sense anymore (it's not just 5 damage)
We do it this way instead of using Strings to avoid mistakes when building decks and writing strings by hand
Mmh, upstream for Godot still down, test pass in local though, feel free to run them on your end too just to be safe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a way to build the deck / AI of an enemy
Related issue(s)
Closes #127
List of changes
Last change is due to targeting, you can have the exact same card, but one is targeting the enemy team, and one is targeting the player. The original choice was that it was easier to not have to switch sides every time (meaning "enemies" is a global truth, doesn't depend on who is attacking). It's easier to understand, but it means some cards will exist in double.
Tests
Tests have been corrected to account for the new structure
Additional notes
Once enemy cards have been given an enemy action name (see global enums), the order of the variants of the enum shouldn't be changed. Since this is simply a value, if we change the order in the enum, the order in the
.tres
of the cards will stay the same, meaning it will be wrongTL;DR : don't change the order of the variants of the EnemyAction enum, you can add more though.
I'll add some demo decks for enemies tomorrow I think.