Issue-139: Add Music #140
Open
Issue-139: Add Music #140
+293
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aying music when starting a new game
…h floor we're on, stop music when we leave game loop
Open
Turtyo
requested changes
Dec 14, 2024
There was a problem hiding this comment.
No issue with the code as is, but I noticed some issues when playing the game:
- There is no sound if I start with something else than a mob fight (in the case I tested, with a dialogue at the start, no music is playing)
- The sound is game is not the same balance as the sound of the original music, it sounds like the music is played stronger on the left than the right ear (mostly noticeable for the area 1 music, but it's present on all musics)
#Scenes/SceneScripts/TestingScene.gd
Outdated
| # Offset by 1 since it's reading from an array | ||
| var current_player_floor: float = PlayerManager.player_position.y + 1 | ||
|
|
||
| var percentage_complete: float = (current_player_floor / number_of_floors) * 100 |
There was a problem hiding this comment.
you can use MapManager.get_map_percent_with_player_position instead to be consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add music and SFX to game
Related issue(s)
#139
List of changes
Added the following tracks
Other changes:
Tests
N/A
Additional notes
N/A