Block #114
Merged
Block #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Turtyo
requested changes
Jul 19, 2024
There was a problem hiding this comment.
I'm not sure why but you seem to like multi-line value assignment, when it's not really necessary.
It follows what we discussed in the issue well, so that works nicely i think. i'll try to think of possible interactions with debuff that could make negative healing for example, as I remember a problem with this, but we might have added a test for it 🤔
assert that health is 100
turned ints to floats
Turtyo
reviewed
Jul 20, 2024
negative check
changed to assign value at the same line as the var
fixed heal
Turtyo
requested changes
Jul 20, 2024
Added remove block on end turn
Turtyo
reviewed
Jul 21, 2024
made floats to ints and also removed bad function
Turtyo
previously approved these changes
Jul 21, 2024
|
Great job on the block 👍 I don't have anything more to ask, actually that end was more me being picky about the types so we don't get conversions everywhere 😆 |
Tomzkk
requested changes
Jul 24, 2024
Turtyo
reviewed
Aug 4, 2024
Tomzkk
approved these changes
Aug 7, 2024
Turtyo
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added block to the game
Related issue(s)
#111
List of changes
Changed Health component to have block
Added a block display to all entities
Added block debug cards
Tests
added some block tests to test_health