Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-81: Splash Art Loading Scene #110

Merged

Conversation

Tysterman74
Copy link
Collaborator

@Tysterman74 Tysterman74 commented Jun 13, 2024

Description

Short splash animation of the Sapling Game Studio logo before navigating to main menu

Related issue(s)

Closes #81

List of changes

A more detailed list of the changes.

  • Added SplashScene.tscn
  • Added SplashScene.gd
  • Added fauna_uuu_test.mp3
  • Updated project settings to change boot screen load color to black
  • Updated project settings to have the SplashScene be the first scene to load instead of Main Menu

Tests

N/A

Additional notes

Sound on.
https://github.com/Saplings-Projects/1M_sub/assets/5923102/0893f4ba-3edc-4db9-ae16-1ecee60cb8b8

Copy link
Collaborator

@Turtyo Turtyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the audio files, we will probably change the way the files are organized later on (basically have them all inside the asset folder, with art on one side and audio on the other side, SFX and music folders).

Visually speaking, there is a little jump to the left on the logo when loading the game. Do you know how to fix that ? Because looking at the code, it shouldn't do that, maybe we'll need to adjust the position manually ? I think it would be good to keep the image at the same size at the start, ie not directly play the animation of the logo changing size.

From an aspect of the animation, ok for the size change but I would keep the lower border of the logo on the lower border of the screen (ie scale relative to an anchor on the bottom and not on the center, I think there is a way to change the anchor point)

#Scenes/SceneScripts/SplashScene.gd Show resolved Hide resolved
#Scenes/SceneScripts/SplashScene.gd Show resolved Hide resolved
@Tysterman74
Copy link
Collaborator Author

fauna_splash_screen_2.mp4

Copy link
Collaborator

@Turtyo Turtyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly sure to understand the transformations you do at the start of the _ready() for the image, i'm guessing it's to change the scaling point of the image ?

#Scenes/SceneScripts/SplashScene.gd Outdated Show resolved Hide resolved
#Scenes/SceneScripts/SplashScene.gd Outdated Show resolved Hide resolved
@Tysterman74
Copy link
Collaborator Author

Pushed up changes to clean up the math of setting position since it got a bit confusing.

Turtyo
Turtyo previously approved these changes Jun 25, 2024
#Scenes/SplashScene.tscn Outdated Show resolved Hide resolved
@Turtyo Turtyo merged commit ba7ac80 into Saplings-Projects:main Jun 27, 2024
1 check passed
@Tysterman74 Tysterman74 deleted the tyty/Issue-81/Splash-Art-Loading branch June 27, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Game splash art loading
3 participants