Skip event button self delete #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip event button will delete itself if DEBUG_SKIP_EVENT is false. SkipEventButton is now available in the node selection menu. SkipEventButton doesnt need to connect its pressed() signal anymore since the _pressed() function is called directly. Also add SkipEventButton to mob and dialogue scene, altho dialogue scene still have bug that prevent any button other than the dialogue button from being pressed.
Turtyo
requested changes
Jun 8, 2024
There was a problem hiding this comment.
I would make the skip button bigger for the mob event and the dialogue event (as it is now, I think it's a bit too small).
I also notice that the button is not enabled by default for the shop and the heal. We can either decide:
- those are temporary screen anyway, if people want to skip them they just need to activate the debug option, and it wont' stay like that for long
- it's better if they are activated by default (even if the debug var is set to false), since you can't do anything if it's not activated
I think we can go for solution 1 honestly, it might add more code that we don't really need, we can already skip by activating the debug var anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skip event button self delete
Related issue(s)
#97
List of changes
Skip event button will delete itself if DEBUG_SKIP_EVENT is false. SkipEventButton is now available in the node selection menu. SkipEventButton doesnt need to connect its pressed() signal anymore since the _pressed() function is called directly.
Also add SkipEventButton to mob and dialogue scene, altho dialogue scene still have bug that prevent any button other than the dialogue button from being pressed.
Tests
If you wrote test scripts to use with GUT, provide a summary of those tests here.
Additional notes
If you have anything more to add.