-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XP system and bar #107
Merged
Merged
XP system and bar #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should a new class be created for the pair (xp_level, Buff) ?
This caused a bug in which we loaded the previous stats after applying the XP buff (thus reverting the changes applied by those buffs)
There is a visual bug left to fix where the XP bar jumps around on the third level (possibly because we don't level up immediately)
Tysterman74
approved these changes
Jun 8, 2024
Paper-2
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the XP system in the game, allowing the player to gain buffs at the start of each combat depending on the amount of XP they have. They gain this XP by soothing enemies.
Related issue(s)
Closes #55
List of changes
Tests
Additional notes
Might add some more tests. There is also a slight visual problem when entering a new combat, the XP bar will "jump" to its correct value. This is because the tween will put it there with a time value of 0, but it's still visible.
A solution would be to calculate the correct value to assign it directly in the ready function.
Another solution is to keep the value stored in the XP manager when the XP bar gets killed, so it can pull the correct value from the XP manager next time it's recreated.
Solution one might imply some code duplication but I could make a function. Solution two feels unnecessary because the XP manager should not have to store something related to the visual state of another object imo. I'm open to suggestions on this.