Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal set add #1123

Merged
merged 3 commits into from
May 3, 2024
Merged

Signal set add #1123

merged 3 commits into from
May 3, 2024

Conversation

wrrobin
Copy link
Collaborator

@wrrobin wrrobin commented May 1, 2024

No description provided.

Copy link
Collaborator

@philipmarshall21 philipmarshall21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Copy link
Member

@davidozog davidozog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is testing against tests-sos commit openshmem-org/tests-sos@26de6ba, is that right?

Perhaps we can update it to tests-sos main, rerun the tests and call it good?

@davidozog
Copy link
Member

@wrrobin - hope you don't mind I manually updated the submodule to point to main (only updating .gitmodules still seems not to be enough). And interestingly, there is a failure with mt_membar with XPMEM+shr_atomics.

@wrrobin
Copy link
Collaborator Author

wrrobin commented May 3, 2024

@wrrobin - hope you don't mind I manually updated the submodule to point to main (only updating .gitmodules still seems not to be enough). And interestingly, there is a failure with mt_membar with XPMEM+shr_atomics.

@davidozog - Did it pass in a rerun?

@davidozog
Copy link
Member

@wrrobin - hope you don't mind I manually updated the submodule to point to main (only updating .gitmodules still seems not to be enough). And interestingly, there is a failure with mt_membar with XPMEM+shr_atomics.

@davidozog - Did it pass in a rerun?

Yes it did... I was unable to reproduce it on neptune, trying Ubuntu now...

Copy link
Member

@davidozog davidozog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That xpmem test passed about 9 or 10 times in a row, so merging. Let's keep an eye on it..

@wrrobin
Copy link
Collaborator Author

wrrobin commented May 3, 2024

Sounds good. Thanks @davidozog

@wrrobin wrrobin merged commit 7857a35 into Sandia-OpenSHMEM:main May 3, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants