-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signal set add #1123
Signal set add #1123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is testing against tests-sos commit openshmem-org/tests-sos@26de6ba, is that right?
Perhaps we can update it to tests-sos main
, rerun the tests and call it good?
@wrrobin - hope you don't mind I manually updated the submodule to point to |
@davidozog - Did it pass in a rerun? |
Yes it did... I was unable to reproduce it on neptune, trying Ubuntu now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That xpmem test passed about 9 or 10 times in a row, so merging. Let's keep an eye on it..
Sounds good. Thanks @davidozog |
No description provided.