Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement file related function and simplify function declaration #313

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

kulcsaradam
Copy link
Contributor

Implement fd_prestat_get, fd_prestat_dir_name and add tests for them. Also simplify function declarations with a marco.

Copy link
Collaborator

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/wasi/fd_advise.wast Outdated Show resolved Hide resolved
@zherczeg
Copy link
Collaborator

Which test needs this?

Implement fd_prestat_get, fd_prestat_dir_name and add tests for them.
Also simplify function declarations with a marco.

Signed-off-by: Ádám László Kulcsár <[email protected]>
@kulcsaradam
Copy link
Contributor Author

C-ray which is a raytracer algorithm on cpu and Typed Stream Format benchmarks use these functions.

http://www.filpizlo.com/tsf/
https://github.com/jtsiomb/c-ray

@clover2123 clover2123 merged commit 977dce0 into Samsung:main Dec 11, 2024
15 checks passed
@zherczeg
Copy link
Collaborator

The ray tracing images are very nice! It is great that we can run it on walrus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants