Enable actions for main branch #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clover2123
force-pushed
the
pr
branch
2 times, most recently
from
2784b49 to
2143604
Compare
clover2123
force-pushed
the
pr
branch
3 times, most recently
from
72fba11 to
ab8ca17
Compare
zherczeg
reviewed
Nov 1, 2023
src/jit/IntMath32Inl.h
Outdated
| @@ -16,6 +16,11 @@ | |||
|
|
|||
| /* Only included by jit-backend.cc */ | |||
|
|
|||
| #if defined(COMPILER_MSVC) | |||
| #include <intrin.h> | |||
| #define __builtin_popcount __popcnt | |||
There was a problem hiding this comment.
Maybe we could use popCount in util/BitOperation.h. This should improve future maintainability.
The header could be included in Backend.cpp so it would be available everywhere.
Signed-off-by: HyukWoo Park <[email protected]>
Signed-off-by: HyukWoo Park <[email protected]>
clover2123
commented
Nov 1, 2023
Comment on lines
-249
to
+254
| return __builtin_popcount(arg); | ||
| return popCount((unsigned)arg); | ||
| } | ||
|
|
||
| static sljit_sw popcnt64(sljit_sw arg) | ||
| { | ||
| return __builtin_popcountl(arg); | ||
| return popCount((unsigned long)arg); |
There was a problem hiding this comment.
@zherczeg I have updated using popCount as you commented.
Please review this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.