Align memory to pointer size. #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GorogPeter
force-pushed
the
alignMemory
branch
from
b41a757 to
a4cbf03
Compare
|
A bit more background: ARM32 just partly support unaligned access. For example all floats/doubles must be 4 byte aligned, and some integer operations such as load/store multiple must be as well. For example, when a 64 bit integer is loaded with load multiple instruction, it must be 4 byte aligned. The byte code is not aligned, but aligning it to pointer size fixes this. The other alternative is use attribute packed on the ByteCode structure. That is just a single line change, but the generated code is less efficient. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some architectures like ARM32 doesn't support non-aligned memory operations thus I aligned the memory.
Without it Walrus crashes on ARM32.