Use mmap, mprotect instead of calloc on POSIX system #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ksh8281
commented
Sep 18, 2023
ksh8281
commented
- Fix default memory maximium size bug
clover2123
reviewed
Sep 20, 2023
| @@ -33,29 +38,76 @@ Memory* Memory::createMemory(Store* store, uint64_t initialSizeInByte, uint64_t | |||
| Memory::Memory(uint64_t initialSizeInByte, uint64_t maximumSizeInByte) | |||
| : m_sizeInByte(initialSizeInByte) | |||
| , m_maximumSizeInByte(maximumSizeInByte) | |||
| , m_buffer(reinterpret_cast<uint8_t*>(calloc(1, initialSizeInByte))) | |||
There was a problem hiding this comment.
Would you add initialization of members m_buffer, m_reservedSizeInByte here?
This will be required by code analysis tools 😢
src/runtime/Memory.cpp
Outdated
Comment on lines
46
to
58
| #if defined(WALRUS_32) | ||
| (1024) * 1024 * 64; | ||
| #else | ||
| (1024) * 1024 * 512; | ||
| #endif |
There was a problem hiding this comment.
Any specific reason for this initial reserved size?
There was a problem hiding this comment.
In 32-bit, we can use only 3GB address. 64MB is practical size.
if we use a lots of address, another code in process like malloc will stop to work.
* Fix default memory maximium size bug Signed-off-by: Seonghyun Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.