Improve performance with large program #1285
Conversation
Signed-off-by: Seonghyun Kim <[email protected]>
Signed-off-by: Seonghyun Kim <[email protected]>
ksh8281
force-pushed
the
work65
branch
3 times, most recently
from
fd2917d
to
6e7fef0
Compare
| @@ -120,7 +120,7 @@ static Value callExportedFunction(ExecutionState& state, Value thisValue, size_t | |||
| // Otherwise, | |||
| // Let values be << >>. | |||
| ValueVector values; | |||
| values.resizeWithUninitializedValues(ret.size); | |||
| values.resizeFitWithUninitializedValues(ret.size); | |||
There was a problem hiding this comment.
What about replacing all the use cases of resizeWithUninitializedValues by resizeFitWithUninitializedValues?
IMO its better to replace them all because the most case of resizeWithUninitializedValues just use the initial size with no extension. Correct this if wrong.
There was a problem hiding this comment.
Some cases use TightVector. so there is no resizeFitWithUninitializedValues needs :(
Signed-off-by: Seonghyun Kim <[email protected]>
| *p = m_transitionTableVectorBufferSize; | ||
| p++; | ||
| *p = m_transitionTableVectorBufferCapacity; |
There was a problem hiding this comment.
IMHO this part of variable segments is a bit confusing,
What about using an union member variables instead?
There was a problem hiding this comment.
I wanted to use union but there is no function to limit union size below 1 byte :(
| ASSERT(propertyCount < 65535); | ||
| if (LIKELY(propertyCount)) { | ||
| m_lastFoundPropertyName = m_properties->back().m_propertyName; | ||
| setLastFoundPropertyIndex(propertyCount - 1); |
There was a problem hiding this comment.
When initialized, the last property info is cached.
Is the last property likely to be accessed after initialization?
There was a problem hiding this comment.
Yes. many programs use last property just after adding it
| m_values.resizeWithUninitializedValues(0, propertyCount); | ||
| bool hasIndexPropertyName = false; | ||
| bool hasSymbolPropertyName = false; | ||
| bool hasNonAtomicPropertyName = false; | ||
| bool hasEnumerableProperty = false; | ||
| ObjectStructureItemVector* keyVector = new ObjectStructureItemVector(); | ||
| keyVector->resizeFitWithUninitializedValues(propertyCount); |
There was a problem hiding this comment.
Here, m_values are initialized with resizeWithUninitializedValues, but keyVector with resizeFitWithUninitializedValues.
Is this intended? what about using the same intializing method for both?
There was a problem hiding this comment.
values vector also uses TightVector(w/ realloc)
No description provided.