Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix global-await issue #1281

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Fix global-await issue #1281

merged 1 commit into from
Dec 1, 2023

Conversation

ksh8281
Copy link
Contributor

@ksh8281 ksh8281 commented Nov 30, 2023

  • Print unhandled reject error for developer in shell
  • Fix await expression parsing bug

@ksh8281
Fix global-await issue
85d9e87 
* Print unhandled reject error for developer in shell
* Fix await expression parsing bug

Signed-off-by: Seonghyun Kim <[email protected]>
@ksh8281
Copy link
Contributor Author

ksh8281 commented Nov 30, 2023

This fixes #1276

clover2123
clover2123 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@clover2123 clover2123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clover2123 clover2123 merged commit 799bc4f into Samsung:master Dec 1, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clover2123 clover2123 clover2123 approved these changes

@bbrto21 bbrto21 Awaiting requested review from bbrto21 bbrto21 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksh8281 @clover2123