Reduce ExecutionState size and compute stacklimit correctly #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th rareData) * This path reduce gc_malloc count for try-catch, with, generator, async function Signed-off-by: Seonghyun Kim <[email protected]>
ksh8281
force-pushed
the
work62
branch
3 times, most recently
from
20b18aa
to
16ffd24
Compare
ksh8281
changed the title
ksh8281
force-pushed
the
work62
branch
9 times, most recently
from
9f802bf
to
82eb49d
Compare
clover2123
reviewed
Nov 20, 2023
src/runtime/ThreadLocal.cpp
Outdated
| stackEndAddress = (char*)stackStartAddress + stackSize; | ||
| #endif | ||
| #endif | ||
| stackSize = std::min(stackSize, (size_t)STACK_USAGE_LIMIT); |
There was a problem hiding this comment.
It seems that stackSize = std::min(stackSize, (size_t)STACK_USAGE_LIMIT); is not used afterward.
|
|
||
| #ifdef STACK_GROWS_DOWN | ||
| UNUSED_VARIABLE(stackEndAddress); | ||
| g_stackLimit = reinterpret_cast<size_t>(stackStartAddress) + STACK_FREESPACE_FROM_LIMIT; |
There was a problem hiding this comment.
This limit means that we only use STACK_FREESPACE_FROM_LIMIT size for stack which is 256 KB,
Am I correct?
There was a problem hiding this comment.
If real stack size is 8MB, we will use (8MB-STACK_FREESPACE_FROM_LIMIT).
remained space used by computing loc when stackoverflow is occured
Comment on lines
+68
to
+73
| context->m_needsExtendedExecutionState = true; | ||
| } else { | ||
| index = context->getRegister(); | ||
| codeBlock->pushCode(LoadLiteral(ByteCodeLOC(m_loc.index), index, Value()), context, this->m_loc.index); | ||
| codeBlock->pushCode(ReturnFunctionSlowCase(ByteCodeLOC(m_loc.index), index), context, this->m_loc.index); | ||
| context->m_needsExtendedExecutionState = true; |
There was a problem hiding this comment.
Is this marking in return statement also necessary?
There was a problem hiding this comment.
ReturnFunctionSlowCase opcode may needs ControlFlowRecord
* Compute stack limit correctly through pthread API or Windows internal API * Store stack limit in TLS(or global) not a VMInstance or ExecutionState Signed-off-by: Seonghyun Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.