Optimize TypedArrayObject.prototype.set, indexOf, lastIndexOf #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ksh8281
commented
Sep 11, 2023
•
ksh8281
commented
- Fix binary precedence bug
|
Fix #1250 |
clover2123
reviewed
Sep 12, 2023
src/builtins/BuiltinTypedArray.cpp
Outdated
Comment on lines
492
to
497
| if (type == TypedArrayType::BigInt64 || type == TypedArrayType::BigUint64) { | ||
| if (!value.isBigInt()) { | ||
| return Value(-1); | ||
| } | ||
| } else { | ||
| if (!value.isNumber()) { |
There was a problem hiding this comment.
What about merging else and if to one else if statement here?
And if these conditions rarely happen, adding UNLIKELY would be good too.
| if (type == TypedArrayType::BigInt64 || type == TypedArrayType::BigUint64) { | ||
| uint64_t argv0ToUint64 = type == TypedArrayType::BigInt64 ? bitwise_cast<uint64_t>(value.asBigInt()->toInt64()) : value.asBigInt()->toUint64(); | ||
| while (compFn(byteK, byteLength)) { | ||
| if (*reinterpret_cast<uint64_t*>(&buffer[byteK]) == argv0ToUint64) { |
There was a problem hiding this comment.
Is it fine to directly access array elements regardless of Endian?
What if we use BigEndian?
There was a problem hiding this comment.
IMO We don't need to care endianness.
because two values are comes from same machine
* Update cmakefile Signed-off-by: Seonghyun Kim <[email protected]>
Signed-off-by: Seonghyun Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.