Draft : [logo/pass] Refactor RemoveDeadNodeWithQueryPass #14051
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor RemoveDeadNodeWithQuery Pass. ONE-DCO-1.0-Signed-off-by: HanJin Choi [email protected]
|
The build failed without any changes.
|
|
@nnfw-bot test nncc-debug |
|
Build and dredd_Test success with code change
|
|
@nnfw-bot test nncc-release |
icodo98
reviewed
Sep 23, 2024
| @@ -141,3 +141,5 @@ Add(REGRESS_ONNX_Conv_BN_Relu6_001 PASS | |||
|
|
|||
| Add(REGRESS_ONNX_Mul_Mul_000 PASS | |||
| convert_nchw_to_nhwc) | |||
|
|
|||
| Add(RemoveDeadNodeWithQueryPass_000 PASS substitute_pack_to_reshape) | |||
There was a problem hiding this comment.
Maybe you should change test title
There was a problem hiding this comment.
I’m not sure if this title is correct.
There was a problem hiding this comment.
I think REGRESS_Issue_13863 would be ok.
|
@nnfw-bot test nncc-debug |
|
@nnfw-bot test nncc-release |
|
Code looks good to me. After all tests are passed, please post PRs module-by-module. |
Thanks a lot! I will change Test title and seperate PRs. :) |
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor RemoveDeadNodeWithQuery Pass.
Related : #13863
ONE-DCO-1.0-Signed-off-by: HanJin Choi [email protected]