[DRAFT][luci/service] Infer pad shape for non-const paddings.

[icodo98]

This supports shape inference of pad when paddings is not constant.

ONE-DCO-1.0-Signed-off-by: JuYoung Lee [email protected]

[icodo98]

related to : #13790

[zetwhite]

How about this?
At first glance, I feel hard to catch the meaning of const paddings.

Suggested change

	// Return shape of pad ops using const paddings.
	loco::TensorShape pad_shape(const loco::TensorShape &input_shape, const luci::CircleNode *paddings);
	// Return shape of pad ops using padding
	// If paddings type is not a CircleConst, return the shape filled with unknown dimensions.
	loco::TensorShape pad_shape(const loco::TensorShape &input_shape, const luci::CircleNode *paddings);

[icodo98]

How about this? At first glance, I feel hard to catch the meaning of const paddings.

Nice point!
I miss the annotation was that of const.
Now we can support non-const paddings with this PR, it should be changed.
I'll fix it.

[seanshpark]

I think there is some misuderstanding of const.
const of const luci::CircleNode *paddings has nothing to do with CircleConst.
Instead, implementation of this method(function) CANNOT modify paddings.

[icodo98]

I think I misunderstood his earlier point. 😂

There seems to be some confusion about the phrase // Return shape of pad ops using const paddings:

1. Interpreting const as referring to const luci::CircleNode *paddings
2. Interpreting it as meaning the padding node is constant

My original intention is the second interpretation, as we only support paddings type with CricleConst.

How about clarifying the sentence by revising it as follows?

Suggested change

	// Return shape of pad ops using const paddings.
	loco::TensorShape pad_shape(const loco::TensorShape &input_shape, const luci::CircleNode *paddings);
	// Return shape of pad ops using paddings.
	// If paddings is not static, return the shape filled with unknown dimensions.
	loco::TensorShape pad_shape(const loco::TensorShape &input_shape, const luci::CircleNode *paddings);

[zetwhite]

looks good to me :)