fix annotation more clear

ONE-DCO-1.0-Signed-off-by: JuYoung Lee [email protected]
Samsung · Sep 8, 2024 · a4ca416 · a4ca416
1 parent c4ca45f
commit a4ca416
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/compiler/luci/service/src/CircleShapeInferenceHelper.h b/compiler/luci/service/src/CircleShapeInferenceHelper.h
@@ -48,7 +48,8 @@ loco::TensorShape circle_shape(const luci::CircleNode *node);
 // Throw an exception if x and y are not broadcastable.
 loco::TensorShape broadcast_shape(const loco::TensorShape &x, const loco::TensorShape &y);
 
-// Return shape of pad ops using const paddings.
+// Return shape of pad ops using paddings.
+// If paddings is static, return the shape filled with unknown dimensions.
 loco::TensorShape pad_shape(const loco::TensorShape &input_shape, const luci::CircleNode *paddings);
 
 /**

diff --git a/compiler/luci/service/src/Nodes/CirclePad.cpp b/compiler/luci/service/src/Nodes/CirclePad.cpp
@@ -32,6 +32,7 @@ namespace sinf
 
 loco::TensorShape Algorithm::visit(const luci::CirclePad *node)
 {
+
   auto paddings = loco::must_cast<const luci::CircleNode *>(node->paddings());
 
   auto circle_input = loco::must_cast<const luci::CircleNode *>(node->input());

diff --git a/compiler/luci/service/src/Nodes/CirclePad.test.cpp b/compiler/luci/service/src/Nodes/CirclePad.test.cpp
@@ -104,7 +104,6 @@ TEST(ShapeRuleTest, pad_non_const_paddings)
 
   node_input->shape({1, 2, 3, 4});
   node_input->shape_status(luci::ShapeStatus::VALID);
-  node_input->dim(2).unset();
 
   node_paddings->dtype(loco::DataType::S64);
   node_paddings->shape({4, 2});
-Original file line number
+Diff line change
@@ Expand Up / @@ -32,6 +32,7 @@ namespace sinf @@
     loco::TensorShape Algorithm::visit(const luci::CirclePad *node)
     {
       auto paddings = loco::must_cast<const luci::CircleNode *>(node->paddings());
       auto circle_input = loco::must_cast<const luci::CircleNode *>(node->input());
@@ Expand Down @@