feat: Start Autoconf Framework #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazWolfe
force-pushed
the
feat/autoconf-framework
branch
from
0a1063f to
6f9e108
Compare
Sammy1Am
requested changes
Apr 1, 2024
KazWolfe
force-pushed
the
feat/autoconf-framework
branch
from
6f9e108 to
e26f653
Compare
- Fix auto fan speed flag inversion - Add temporary HVaneSwing control field - Move getSupportedFanSpeeds to .cpp file - Add core traits converter
- Add new _capabilitiesRequested field to track if we've asked for capabilities yet (in a non-blocking way). - Tie HVaneSwing support to regular vane swing.
KazWolfe
force-pushed
the
feat/autoconf-framework
branch
from
e26f653 to
f4f5d11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of the PR #17 for maintainer sanity, and starts work on Sammy1Am/temp-issues#9.
.cppfile for packets.packet.asTraits()to quickly get core heatpump-supported features.