Feat/upgradefileupload #1633
Closed
Feat/upgradefileupload #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 7, 2024 20:16
Snorre98
reviewed
Dec 10, 2024
There was a problem hiding this comment.
Behold kommentarene som var på line 87, 89 og 99
| label?: ReactNode; | ||
| existing_url?: string; |
There was a problem hiding this comment.
Suggested change
| existing_url?: string; | |
| localFileUrl?: string; |
og for resten seff.
Comment on lines
+212
to
+216
| <SamfFormField | ||
| field="file" | ||
| type="file" | ||
| props={{ existing_url: 'http://localhost:3000/src/assets/logos/uka.png' }} | ||
| /> |
There was a problem hiding this comment.
Dette bør vel kun rendres hvis stillingen har mulighet for fil opplasting.
Vi bruker ikke Samfform lengre btw. Gått over til ReactHook-form
| @@ -132,6 +133,7 @@ export const SamfFormGenerators: Record<SamfFormFieldType, GeneratorFunction<any | |||
| date_time: makeStandardInputFunction<Date>('datetime-local'), | |||
| date: makeStandardInputFunction<Date>('date'), | |||
| time: makeStandardInputFunction<Date>('time'), | |||
| file: makeFilePickerFunction('any'), | |||
There was a problem hiding this comment.
Vi bruker ikke Samfform lengre btw. Gått over til ReactHook-form
| <SamfFormField | ||
| field="file" | ||
| type="file" | ||
| props={{ existing_url: 'http://localhost:3000/src/assets/logos/uka.png' }} |
There was a problem hiding this comment.
trengs det en default her?
|
Oja okay, da får jeg vell fjerne denne dersom vi heller bruker react hook form |
Ja, gjerne lukk denne om du ser den ikke trengs med tanke på at vi bruke React Hook form |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File upload was a bit restricted, added any type and fixed up design