Feature/upgradeapplicantstateview #1603
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@magsyg Jeg har en PR på akkurat dette |
robines
requested changes
Nov 7, 2024
backend/root/utils/routes.py
Outdated
| @@ -564,6 +564,7 @@ | |||
| samfundet__interview_list = 'samfundet:interview-list' | |||
| samfundet__interview_detail = 'samfundet:interview-detail' | |||
| samfundet__api_root = 'samfundet:api-root' | |||
| samfundet__api_root = 'samfundet:api-root' | |||
backend/samfundet/urls.py
Outdated
| @@ -105,6 +105,11 @@ | |||
| views.RecruitmentApplicationForGangUpdateStateView.as_view(), | |||
| name='recruitment_application_update_state_gang', | |||
| ), | |||
| path( | |||
| 'recruitment-position-organized-applications/<slug:pk>/', | |||
There was a problem hiding this comment.
Er det som er gjort andre steder
There was a problem hiding this comment.
Slug er litt misvisende syns jeg, her er det jo en ID som brukes. Slug er mer for strings som er gjort URL-vennlig.
For eksempel: https://stackoverflow.com/questions/4230846/what-is-the-etymology-of-slug-in-a-url
Her er what-is-the-etymology-of-slug-in-a-url slugen, som er generert fra tittelen What is the etymology of 'slug' in a URL?
There was a problem hiding this comment.
Oki byttet det til id
magsyg
force-pushed
the
feature/upgradeapplicantstateview
branch
from
a68d435 to
c4abc08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a view for and serializer where applicants are organized
Before it was done in frontend, now it is moved to backend
This will also make it easier to fetch the status with how dynamic it is