Use Biome unused imports and top-level hooks rules (#1626)

* Use unused import and top-level hooks rule * Remove unused imports * Remove enabled argument from UserFeedback (fixes top-level hooks error) It's also better to disable the component by just not rendering it, instead of dealing with enabled state.
Samfundet · Dec 16, 2024 · 5cd8ee9 · 5cd8ee9
1 parent f6f38b8
commit 5cd8ee9
Show file tree

Hide file tree

Showing 9 changed files with 14 additions and 19 deletions.
diff --git a/biome.jsonc b/biome.jsonc
@@ -28,7 +28,11 @@
   "linter": {
     "enabled": true,
     "rules": {
-      "recommended": true
+      "recommended": true,
+      "correctness": {
+        "noUnusedImports": "error",
+        "useHookAtTopLevel": "error"
+      }
     }
   },
   "formatter": {

diff --git a/frontend/src/App.tsx b/frontend/src/App.tsx
@@ -28,7 +28,7 @@ export function App() {
 
   return (
     <HelmetProvider>
-      <UserFeedback enabled={true} />
+      <UserFeedback />
       {goatCounterCode && (
         <Helmet>
           {/* Helmet is linked to <head>. Used to add scripts. */}

diff --git a/frontend/src/Components/DatePicker/DatePicker.tsx b/frontend/src/Components/DatePicker/DatePicker.tsx
@@ -1,7 +1,7 @@
 import { Icon } from '@iconify/react';
 import classNames from 'classnames';
 import { format } from 'date-fns';
-import React, { forwardRef, useMemo } from 'react';
+import { forwardRef, useMemo } from 'react';
 import { useState } from 'react';
 import { useTranslation } from 'react-i18next';
 import { MiniCalendar } from '~/Components';

diff --git a/frontend/src/Components/Dropdown/Dropdown.stories.tsx b/frontend/src/Components/Dropdown/Dropdown.stories.tsx
@@ -1,4 +1,4 @@
-import type { ComponentMeta, ComponentStory, Meta, StoryObj } from '@storybook/react';
+import type { Meta, StoryObj } from '@storybook/react';
 import { Dropdown } from './Dropdown';
 
 // Local component config.

diff --git a/frontend/src/Components/RecruitmentApplicantsStatus/RecruitmentApplicantsStatus.tsx b/frontend/src/Components/RecruitmentApplicantsStatus/RecruitmentApplicantsStatus.tsx
@@ -1,10 +1,9 @@
 import { useTranslation } from 'react-i18next';
-import { InputField, TimeDisplay } from '~/Components';
+import { TimeDisplay } from '~/Components';
 import { CrudButtons } from '~/Components/CrudButtons/CrudButtons';
 import { Dropdown, type DropdownOption } from '~/Components/Dropdown/Dropdown';
 import { Table } from '~/Components/Table';
 import { Text } from '~/Components/Text/Text';
-import { putRecruitmentApplicationForGang } from '~/api';
 import type { RecruitmentApplicationDto, RecruitmentApplicationStateDto } from '~/dto';
 import { useCustomNavigate } from '~/hooks';
 import { KEY } from '~/i18n/constants';

diff --git a/frontend/src/Components/UserFeedback/UserFeedback.stories.tsx b/frontend/src/Components/UserFeedback/UserFeedback.stories.tsx
@@ -8,7 +8,7 @@ export default {
 } as ComponentMeta<typeof UserFeedback>;
 
 const Template: ComponentStory<typeof UserFeedback> = () => {
-  return <UserFeedback enabled={true} />;
+  return <UserFeedback />;
 };
 
 export const Primary = Template.bind({});
diff --git a/frontend/src/Components/UserFeedback/UserFeedback.tsx b/frontend/src/Components/UserFeedback/UserFeedback.tsx
@@ -10,23 +10,15 @@ import { useTextItem } from '~/hooks';
 import { KEY } from '~/i18n/constants';
 import styles from './UserFeedback.module.scss';
 
-type UserFeedbackProps = {
-  enabled: boolean;
-};
-
 type FormProps = {
   text: string;
   contact_email?: string;
 };
 
-export function UserFeedback({ enabled }: UserFeedbackProps) {
+export function UserFeedback() {
   const { t } = useTranslation();
   const [isOpen, setIsOpen] = useState(false);
 
-  if (!enabled) {
-    return <div />;
-  }
-
   const handleFormSubmit = (formData: FormProps) => {
     postFeedback({
       ...formData,

diff --git a/...OverviewPage/components/RecruitmentInterviewGroupsList/RecruitmentInterviewGroupsList.tsx b/...OverviewPage/components/RecruitmentInterviewGroupsList/RecruitmentInterviewGroupsList.tsx
@@ -2,8 +2,8 @@ import { useEffect, useState } from 'react';
 import { useTranslation } from 'react-i18next';
 import { useParams } from 'react-router-dom';
 import { toast } from 'react-toastify';
-import { getRecruitmentSharedInterviewGroups, getRecruitmentStats } from '~/api';
-import type { RecruitmentSharedInterviewGroupDto, RecruitmentStatsDto } from '~/dto';
+import { getRecruitmentSharedInterviewGroups } from '~/api';
+import type { RecruitmentSharedInterviewGroupDto } from '~/dto';
 import { KEY } from '~/i18n/constants';
 import styles from './RecruitmentInterviewGroupsList.module.scss';
 import { RecruitmentInterviewGroupComponent } from './components/RecruitmentInterviewGroupComponent/RecruitmentInterviewGroupComponent';

diff --git a/...List/components/RecruitmentInterviewGroupComponent/RecruitmentInterviewGroupComponent.tsx b/...List/components/RecruitmentInterviewGroupComponent/RecruitmentInterviewGroupComponent.tsx
@@ -1,5 +1,5 @@
 import { ExpandableHeader, Table } from '~/Components';
-import type { RecruitmentSharedInterviewGroupDto, RecruitmentStatsDto } from '~/dto';
+import type { RecruitmentSharedInterviewGroupDto } from '~/dto';
 import { dbT } from '~/utils';
 import styles from './RecruitmentInterviewGroupComponent.module.scss';