Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from elastic:main #503

Merged
merged 115 commits into from
Sep 28, 2024
Merged

[pull] main from elastic:main #503

merged 115 commits into from
Sep 28, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Sep 26, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

elasticsearchmachine and others added 30 commits September 25, 2024 14:52
…esql/60_usage/Basic ESQL usage output (telemetry)} #113502
These abstract classes are now unused so this commit removes them.
Since we are enriching the component templates with more entries such as
the data stream lifecycle and in the future the data stream options, we
add a template builder to help with the code, especially tests.

To highlight the value and prepare for the PRs that will add the data
stream options to the template we replace calls to the constructor with
all arguments by the builder: - when there are aguements with null
values, or - when we copy another template and change only a few fields.

This prepares the ground, so when we add data stream options, we will
not need to edit all these places.
…2992)

Restores the changes from #111684 which uses multiple streams to improve the
time to download and install the built in ml models. The first iteration has a problem
where the number of in-flight requests was not properly limited which is fixed here.
Additionally there are now circuit breaker checks on allocating the buffer used to 
store the model definition.
Add initial code required to fallback synthetic source mode to stored
source mode using an index settings provider.

Note that the final version relies on a new index setting  that
determines source mode, which is currently controlled by  `mode` mapping
attribute in `_source` meta field mapper. Additionally index modes
should not enforce synthetic source mode.
A
[change](https://github.com/elastic/elasticsearch/pull/111865/files#diff-f35477bd1eef27ca0cfd9e94205799a6ff7f64e02a658e456051e400f08db061R1774-R1799)
in the `indexRandom` method resulted in test failures due to unexpected
switches to system user processing during bulk index creation calls. It
has since been
[reverted](#113416), so
this PR unmutes the relevant tests. Will monitor for failures.

Resolves: #113345
Resolves: #113341
Resolves: #113338
Resolves: #113328
Resolves: #113311
Resolves: #113285
Resolves: #113260
Resolves: #113185
Some `getClientWrapper()` implementations return a wrapper that only
wraps `NodeClient` instances. In practice we _only_ wrap `NodeClient`
instances so this check is redundant, and in a recent investigation it
was confusing to readers. With this commit we assert that we're always
wrapping a `NodeClient`.
* Remove match command

* Remove assertMatchCommand

* Remove unused import
Adding `security_solution-*-*` in list of index nae to avoid the pattern collisions.
It's in the title, prerequisite for #113164
… {p0=dot_prefix/10_basic/Deprecated index template with a dot prefix index pattern} #113529
The formatting of this comment was destroyed by spotless. This commit
fixes this.
The parsing logic is test only at this point, lets move it to tests
accordingly to keep the prod codebase a little smaller.
Also fixed a missing `static`.
…tringFunctionTests org.elasticsearch.xpack.esql.expression.function.fulltext.QueryStringFunctionTests #113496
Those test were failing for a missing backport with the following error:

```
stack_trace":"java.io.IOException: Can't read unknown type [111]\n\tat [email protected]
```

The backport is done so we can just unmute them.

fixes #113502 fixes
#113497
…st {p0=search/180_locale_dependent_mapping/Test Index and Search locale dependent mappings / dates} #113537
…esql/70_locale/Date format with default locale} #113539
…esql/70_locale/Date format with Italian locale} #113540
* Renaming - code mentioned modelId but was actually deploymentId

* Documenting

* add a test case and more renaming

* Renaming & remove TODOs

* Update MlAutoscalingStats javadoc to match autoscaler comments

* precommit
Today in the ML and Transform plugins we use `null` for timeouts related
to persistent tasks, which means to use the implicit default timeout of
30s. As per #107984 we want to eliminate all such uses of the implicit
default timeout. This commit either moves to using the timeout from the
associated transport request, if available, or else makes it explicit
that we're using a hard-coded 30s timeout.
…I embedding endpoints (#112074)

* Adding ChunkingSettings logic and enabling ChunkingSettings for OpenAI embedding endpoints

* Cleaning up naming in ChunkingSettings logic

* Incrementing InferenceIndex version

* Removing DefaultChunkingSettings, cleaning up chunking settings class and related tests, add chunking strategy to inference index

* Adding check for up to date index mappings when creating an inference endpoint

* Fixing transport version conflict

* Adding validation for invalid chunking settings inputs and improving error messaging

* Reverting SystemIndexMappingUpdateService changes and adding error messaging on mixed cluster exception
Deprecate to, from, include_lower, include_upper range query params.
These params have been removed from our documentation in v. 0.90.4 (d6ecdec),
but did not got through deprecation cycle.

These params to be removed in v9.0.

Related to #81276

Closes #48538
DaveCTurner and others added 29 commits September 27, 2024 10:59
Very often we want to assert the exception type, possibly after
unwrapping any `ElasticsearchWrapperException` layers. This commit adds
utilities to better support these cases.
Same as #113572 but targeting `8.x` and `main`.
We're trying to flatten away our clone of QL called `esql-core` so that
it's easier to work on ESQL directly. This bit moves cleanly.
Today we keep track of a data stream's index mode. However if index mode
is logsdb, then we don't set it at data stream level. We only set it is
index mode is time series.

This change keeps track of logsdb index mode at data stream creation and
rollover time.

Followup changes: * Update the get data stream api to return that a data
stream is in logsdb mode. (today we do return additional information in
case of time series data stream) * Update the
IndexSettingProvider#getAdditionalIndexSettings(...) parameter list by
including `indexMode` instead of `isTimeSeries`.

Relates to #113583
…CacheDisablingInterceptorTests testRequestCacheWillBeDisabledWhenSearchRemoteIndices #113659
)

* Note in docs about incorrect IO stats when running in docker

* Update docs/reference/cluster/nodes-stats.asciidoc

Co-authored-by: David Turner <[email protected]>

* Requested PR changes to wording

* Update docs/reference/cluster/nodes-stats.asciidoc

Co-authored-by: David Turner <[email protected]>

---------

Co-authored-by: David Turner <[email protected]>
We need to be able to assert various warnings and check for such in
typical token stream tests. This adds that capability.
Adjust existing log and metric for undesired allocations to consider
only non-shutting-down nodes.

Closes ES-7849
Adds inner hits support to the semantic query through a restricted inner_hits parameter, which exposes from and size from the inner_hits options
)

It seems that JDK23 yields a different error message if the connection
is closed before even sending headers. This commit relaxes the assertion
to match, and also tightens it up to check that we report a premature
end of the body if we _do_ send headers.
Resolves #113632

Fixes a test that relied on order without sorting.
The option is only enabled for test clusters, and turns on features that are only present in tests
Else, a reset might reset to an unintended offset in a big slice.

Also add support for skip.

Relates ES-9639
Adds a new option trace_redact in redact processor to indicate a document has been redacted in the ingest pipeline. If a document is processed by a redact processor AND any field is redacted, ingest metadata _ingest._redact._is_redacted = true will be set.

Closes #94633
We are current using Float.MIN_VALUE which is the smallest positive non-zero value, not the smallest possible value. 
This commit change it to -Float.MAX_VALUE to be symmetric to the double max aggregation.
…ode (#113650)

This moves the remainining few parsers out of prod code now that we only
need this logic for testing with the HLRC gone.
Previously, when GetAliases was called with multiple indices that share
an alias, findAliases would recheck the alias against the supplied alias
patterns for each index that used it. This change memoizes the pattern
check to avoid that redundant work.

Closes #102676
…per (#113522)

Adds logic to SyntheticSourceIndexSettingsProvider to check source field mapper to whether synthetic source is enabled.

Before this change the SyntheticSourceIndexSettingsProvider would only check the index.mode setting, which doesn't cover all usages of synthtic source.
Update Gradle wrapper to 8.10.2
…13711)

* Propagate `supportsObjectAutoFlattening` in DocumentParserContext

* remove noop
…g.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT #113730
@pull pull bot merged commit 2f192e8 into Samboski1:main Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.