Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE 248 BRANCH #672

Merged
merged 6 commits into from
Nov 17, 2023
Merged

FEATURE 248 BRANCH #672

merged 6 commits into from
Nov 17, 2023

Conversation

jjbennett
Copy link
Contributor

@jjbennett jjbennett commented Aug 14, 2023 •
edited by salesforce-org-metaci bot
Loading

Critical Changes

Changes

Issues Closed

New Metadata

Deleted Metadata

Definition of Done

Refer to Asteroids DoD document to see any additional details for the items below

  • Any net new LWC work has Sa11y tests & 50% or above lines JEST test coverage
  • CRUD/FLS is enforced in Apex
  • Permission sets are updated to account for CRUD|FLS|Tab|Classes
  • Field sets are updated to account for new fields
  • UX approval or UX not necessary
  • Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name (Reorganize code; use custom iterator #303)
  • All acceptance criteria have been met
    • Developer
    • Code Reviewer
    • QA
  • PR contains draft release notes
  • QE story level testing completed

Unaggregated Pull Requests

  • Debounce BSDT Save Button [PR673]
  • Service Schedule Modal Error [PR674]

@jjbennett jjbennett marked this pull request as draft August 14, 2023 18:41
@AndersonTarren AndersonTarren self-requested a review November 17, 2023 14:24
@AndersonTarren AndersonTarren marked this pull request as ready for review November 17, 2023 15:34
@jjbennett jjbennett changed the title DO NOT MERGE: FEATURE 248 BRANCH FEATURE 248 BRANCH Nov 17, 2023
@jjbennett jjbennett merged commit b2c79ee into main Nov 17, 2023
7 checks passed
@jjbennett jjbennett deleted the feature/248 branch November 17, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTarren AndersonTarren AndersonTarren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjbennett @AndersonTarren