Remove hard-coded prefix on container group name, create dummy ProblemDetails from unknown errors #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtroyer-salad
changed the title
We have project names to disambiguate these on the SCE side and namespaces on the K8s side. Signed-off-by: Dean Troyer <[email protected]>
utils.GetResponseBody() can return an unknown_error type if the response Body fails to decode as JSON. This will bubble the remote error rather than log a "failed to decode" message. Signed-off-by: Dean Troyer <[email protected]>
Signed-off-by: Dean Troyer <[email protected]>
Signed-off-by: Dean Troyer <[email protected]>
Signed-off-by: Dean Troyer <[email protected]>
|
Rebased and refreshed on top of the now-merged Dependabot updates. This is the branch used in the demos. |
seniorquico
requested changes
Nov 29, 2023
Signed-off-by: Dean Troyer <[email protected]>
seniorquico
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have project names to disambiguate these on the SCE side and namespaces on the K8s side.