Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Schematic-90] Use synapseclient user-agent string to track schematic library and CLI usage #1569

Merged
merged 4 commits into from
Jan 28, 2025
Merged

[Schematic-90] Use synapseclient user-agent string to track schematic library and CLI usage #1569

merged 4 commits into from
Jan 28, 2025

Conversation

SageGJ
Copy link
Contributor

@SageGJ SageGJ commented Jan 24, 2025 •
edited
Loading

Resolves SCHEMATIC-190 and sets the synapseclient USER_AGENT string as discussed in the accompanying design document.

@SageGJ SageGJ changed the title Schematic 190 schematic usage tracking [Schematic-90] Use synapseclient user-agent string to track schematic library and CLI usage Jan 28, 2025
@SageGJ SageGJ marked this pull request as ready for review January 28, 2025 17:30
@SageGJ SageGJ requested a review from a team as a code owner January 28, 2025 17:30
BryanFauble
BryanFauble approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@SageGJ SageGJ merged commit c50c599 into develop Jan 28, 2025
8 checks passed
@SageGJ SageGJ deleted the schematic-190-schematic-usage-tracking branch January 28, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryanFauble BryanFauble BryanFauble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SageGJ @BryanFauble