Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All domains #2

Merged
merged 15 commits into from
Jan 14, 2021
Merged

All domains #2

merged 15 commits into from
Jan 14, 2021

Conversation

jwildfire
Copy link
Contributor

Adding all data domains

@jwildfire jwildfire requested a review from rescalan January 8, 2021 15:59
@jwildfire jwildfire self-assigned this Jan 8, 2021
Copy link
Contributor

@rescalan rescalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work adding all those datasets. I'll reorganize the code base in R and I'll send a new PR on this branch.

@@ -0,0 +1,54 @@
# Make sure working directory is set to root for the pacakge (not ./data-raw or ./data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than adding this comment we can use the r-package {here} to specify paths. It will default to the home folder


# Copy csv files in /data-raw to /data and create roxygen documentation in /R
paths<-list.files(
"data-raw",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then this line would be

here::here("data-raw")

}

# Generate basic roxygen documentation
# Thanks to: https://stackoverflow.com/questions/51092509/whats-the-best-way-to-automatically-generate-roxygen2-documentation-for-a-data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty neat.

@jwildfire
Copy link
Contributor Author

Latest commit adds a subfolder in data-raw and prefixes files with sdtm_ in data in preparation for #4

Copy link
Contributor

@rescalan rescalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll test some safetyCharts functionality with these new datasets too.

@jwildfire jwildfire merged commit 1f7ea8e into main Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants