-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All domains #2
All domains #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work adding all those datasets. I'll reorganize the code base in R and I'll send a new PR on this branch.
data-raw/prepareData.R
Outdated
@@ -0,0 +1,54 @@ | |||
# Make sure working directory is set to root for the pacakge (not ./data-raw or ./data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than adding this comment we can use the r-package {here} to specify paths. It will default to the home folder
data-raw/prepareData.R
Outdated
|
||
# Copy csv files in /data-raw to /data and create roxygen documentation in /R | ||
paths<-list.files( | ||
"data-raw", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then this line would be
here::here("data-raw")
data-raw/prepareData.R
Outdated
} | ||
|
||
# Generate basic roxygen documentation | ||
# Thanks to: https://stackoverflow.com/questions/51092509/whats-the-best-way-to-automatically-generate-roxygen2-documentation-for-a-data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty neat.
Use {here} for easier file referencing
Latest commit adds a subfolder in data-raw and prefixes files with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'll test some safetyCharts functionality with these new datasets too.
Adding all data domains