Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

htmlwidget reporting updates #52

Merged
merged 4 commits into from
Apr 23, 2021
Merged

htmlwidget reporting updates #52

merged 4 commits into from
Apr 23, 2021

Conversation

jwildfire
Copy link
Contributor

Summary

This PR along with SafetyGraphics/safetyGraphics#526 fixes issues in htmlwidget reporting. Including those in #49.

Now all standard renderers expect for AE Timelines should be working well in safetyGraphics reports. See #51 for a summary of the AE Timelines issues.

Test Notes.

Same as SafetyGraphics/safetyGraphics#526 - Make sure all exported charts work as expected using the following branches:

devtools::install_github("safetyGraphics/safetyCharts", ref="fix-49")
library(safetyCharts)
devtools::install_github("safetyGraphics/safetyGraphics", ref="reports-updates")
library(safetyGraphics)
safetyGraphics::safetyGraphicsApp()

@jwildfire jwildfire requested review from samussiah and xni7 April 20, 2021 17:18
@elimillera
Copy link
Contributor

Per SafetyGraphics/safetyGraphics#522,

I reviewed the charts and they looked all good to me with the exception of the Hepatic Explorer

@jwildfire
Copy link
Contributor Author

Let's make sure that hep-explorer is working for someone other than me before we merge.

@xni7 @samussiah @bzkrouse - could one of you take a quick look and see if it runs in the app and export?

@jwildfire jwildfire merged commit 0044623 into dev Apr 23, 2021
@jwildfire jwildfire deleted the fix-49 branch March 23, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants