Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

136 integrate measure values input in chart with the mappings tab defaults control in upper right #159

Merged
merged 9 commits into from
Oct 25, 2024
Merged

136 integrate measure values input in chart with the mappings tab defaults control in upper right #159

merged 9 commits into from
Oct 25, 2024

Conversation

Lovemore-Gakava
Copy link
Contributor

Integrate measure values input in chart with the mappings tab defaults control in upper right

  • Extend color palatte to accomodate more lab tests beyond the default.
  • Update picker.

Lovemore-Gakava and others added 8 commits October 4, 2024 18:20
@Lovemore-Gakava
fix:
1fb71c0 
- nepexplorerMod: Update sidebar to only have default labs for profile
- patient_profile_mod:remove default_labs processing and use the declared ones from nepexplorerMod
- update documentation
@Lovemore-Gakava
fix: Branch was created from master instead of dev. Dev is the branch…
00ca745 
… with the latest update. I have merged dev to the updates to this branch.

Merge branch 'dev' into 136-integrate-measure-values-input-in-chart-with-the-mappings-tab-defaults-control-in-upper-right

# Conflicts:
#	.Rbuildignore
#	.gitignore
#	R/nepexplorerMod.R
#	R/patient_profile_mod.R
#	man/patientProfileServer.Rd
@Lovemore-Gakava
fix: extend color palatte to accomodate more lab tests beyond the def…
ba62c6d 
…ault.
@Lovemore-Gakava
Update picker.
f964bbb
@Lovemore-Gakava
Added shinyWidgets package declaration for pickerInput
577e1c1
@Lovemore-Gakava
fix:
a4b3d02 
patient_profile_mod.R,line=148,col=2,[trailing_blank_lines_linter] added Missing terminal newline
patient_profile_charts.R: added importFrom grDevices colorRampPalette
@Lovemore-Gakava
rm: Non-standard file/directory found at top level:
e68aab4 
    '_pkgdown.yml
@Lovemore-Gakava
fix: add shinywidgets dependency.
e1ac576
@pburnsdata
Copy link
Contributor

pburnsdata commented Oct 25, 2024 •
edited
Loading

@Lovemore-Gakava I friggin love this. Super cool to see this working.

I made one tweak: set it to only use color generator when there's more than 19 labs because the default 19 colors you put together were more divergent than those that the generator created. When there's only like 5 labs the generator made colors for me that were too close together when they didn't need to be.

@Lovemore-Gakava
Copy link
Contributor Author

Thanks @pburnsdata - love the tweak!

@pburnsdata pburnsdata merged commit 847f9d3 into dev Oct 25, 2024
8 checks passed
@pburnsdata pburnsdata deleted the 136-integrate-measure-values-input-in-chart-with-the-mappings-tab-defaults-control-in-upper-right branch October 25, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pburnsdata pburnsdata Awaiting requested review from pburnsdata

@lgakava lgakava Awaiting requested review from lgakava

@elimillera elimillera Awaiting requested review from elimillera

@jwoolfolk jwoolfolk Awaiting requested review from jwoolfolk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lovemore-Gakava @pburnsdata