Update dataset.py, change recursive __getitem__ to while loop; fix finetune_gradio.py #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change recursive approach to while loop, avoiding potential memory leak.
…etune_gradio.py Update `get_random_sample_transcribe` to handle absolute paths in `finetune_gradio.py` - Added support for processing absolute file paths during transcription. - Updated logic to correctly handle and return audio file paths with absolute URLs. - Example use case: URLs like `https://localhost:55555/speech/150/150896/150-150896-40.wav.wav`. - Correct one should be: `https://localhost:55555/speech/150/150896/150-150896-40.wav`.
SWivid
changed the title
SWivid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change recursive approach in
__getitem__function (CustomDatasetclass) to while loop, avoiding potential memory leak.Assumption: Recursive Calls in getitem Leading to Memory Leak
Potential Problem: If there are consecutive samples with invalid durations, this recursive call can lead to a deep recursion stack, consuming a significant amount of memory and possibly causing a stack overflow.
Update
get_random_sample_transcribeto handle absolute paths infinetune_gradio.py~/datasets/multi-tts/th/150/150896/150-150896-40.wav.wav.