Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --bnb_optimizer argument to CLI and pass it to Trainer initialization #401

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

hcsolakoglu
Copy link
Contributor

Add --bnb_optimizer argument to CLI and pass it to Trainer initialization.

  • Add --bnb_optimizer argument to parse_args() function in src/f5_tts/train/finetune_cli.py.
  • Pass bnb_optimizer argument to Trainer initialization in the main() function of src/f5_tts/train/finetune_cli.py.

…tion

Add `--bnb_optimizer` argument to CLI and pass it to Trainer initialization.

* Add `--bnb_optimizer` argument to `parse_args()` function in `src/f5_tts/train/finetune_cli.py`.
* Pass `bnb_optimizer` argument to `Trainer` initialization in the `main()` function of `src/f5_tts/train/finetune_cli.py`.
@SWivid
Copy link
Owner

SWivid commented Nov 5, 2024

Hi @hcsolakoglu , we added 8bit-Adam yet not tried.
Would you like to share some test results (e.g. the mem usage and performance) ?

@SWivid SWivid merged commit 8a7e849 into SWivid:main Nov 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants