Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle GPT exception with null barcode #148

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Handle GPT exception with null barcode #148

merged 1 commit into from
Oct 31, 2023

Conversation

inh2613
Copy link
Member

@inh2613 inh2613 commented Oct 31, 2023

PR Type

  • 기능 추가
  • 기능 삭제
  • 버그 수정
  • 테스트 코드 작성
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 문서 작성

Motivation

barcode를 nullable로 변경하면서, GPT barcode 파싱에 실패해도 null인채로 저장됨

Problem Solving

GPT의 response에서 barcode, expires_at 예외처리

To Reviewer

@inh2613 inh2613 added 🐛 bug Something isn't working 💳 Voucher 기프티콘과 관련된 라벨 labels Oct 31, 2023
@inh2613 inh2613 requested a review from jinlee1703 October 31, 2023 05:22
@inh2613 inh2613 self-assigned this Oct 31, 2023
jinlee1703
jinlee1703 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@jinlee1703 jinlee1703 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@inh2613 inh2613 merged commit 07323e7 into develop Oct 31, 2023
2 checks passed
@inh2613 inh2613 deleted the fix/GH-384-gpt-barcode-parse-error branch October 31, 2023 07:00
jinlee1703 pushed a commit that referenced this pull request Nov 5, 2023
@inh2613
fix/GH-148-voucher-read-access-right (#43)
8fa2b2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinlee1703 jinlee1703 jinlee1703 approved these changes

Assignees

@inh2613 inh2613

Labels
🐛 bug Something isn't working 💳 Voucher 기프티콘과 관련된 라벨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inh2613 @jinlee1703